Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1068783005: {Request, Response}.blob() should release its lock when resolved. (Closed)

Created:
5 years, 8 months ago by yhirano
Modified:
5 years, 8 months ago
Reviewers:
hiroshige
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@request-body-setting
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

{Request, Response}.blob() should release its lock when resolved. Request.blob() and Response.blob() should read all data from their body and release the reader when reading is finished. Previously the implementation acquired the lock permanently by mistake, so this CL fixes that. BUG=477995 R=hiroshige@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194190

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M LayoutTests/http/tests/fetch/script-tests/request.js View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/response.js View 1 2 3 4 1 chunk +9 lines, -1 line 0 comments Download
M Source/modules/fetch/Body.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
yhirano
5 years, 8 months ago (2015-04-17 09:30:34 UTC) #1
yhirano
On 2015/04/17 09:30:34, yhirano wrote: PS2 addressed the point pointed at https://codereview.chromium.org/1088823002/#msg8 .
5 years, 8 months ago (2015-04-17 09:35:12 UTC) #2
hiroshige
Should we have a test for Response?
5 years, 8 months ago (2015-04-17 09:45:17 UTC) #3
yhirano
On 2015/04/17 09:45:17, hiroshige wrote: > Should we have a test for Response? Done.
5 years, 8 months ago (2015-04-21 06:47:37 UTC) #4
hiroshige
lgtm. https://codereview.chromium.org/1068783005/diff/60001/LayoutTests/http/tests/fetch/script-tests/response.js File LayoutTests/http/tests/fetch/script-tests/response.js (right): https://codereview.chromium.org/1068783005/diff/60001/LayoutTests/http/tests/fetch/script-tests/response.js#newcode318 LayoutTests/http/tests/fetch/script-tests/response.js:318: }).then(function(blob) { Please add a comment that states ...
5 years, 8 months ago (2015-04-21 07:17:13 UTC) #5
yhirano
https://codereview.chromium.org/1068783005/diff/60001/LayoutTests/http/tests/fetch/script-tests/response.js File LayoutTests/http/tests/fetch/script-tests/response.js (right): https://codereview.chromium.org/1068783005/diff/60001/LayoutTests/http/tests/fetch/script-tests/response.js#newcode318 LayoutTests/http/tests/fetch/script-tests/response.js:318: }).then(function(blob) { On 2015/04/21 07:17:13, hiroshige wrote: > Please ...
5 years, 8 months ago (2015-04-22 02:35:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068783005/80001
5 years, 8 months ago (2015-04-22 02:35:39 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 03:53:18 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194190

Powered by Google App Engine
This is Rietveld 408576698