Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Side by Side Diff: cc/surfaces/onscreen_display_client.cc

Issue 1068743003: Revert of Add DisplayScheduler for Surfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/surfaces/onscreen_display_client.h ('k') | mojo/services/surfaces/display_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/surfaces/onscreen_display_client.h" 5 #include "cc/surfaces/onscreen_display_client.h"
6 6
7 #include "base/trace_event/trace_event.h" 7 #include "base/trace_event/trace_event.h"
8 #include "cc/output/output_surface.h" 8 #include "cc/output/output_surface.h"
9 #include "cc/scheduler/begin_frame_source.h"
10 #include "cc/surfaces/display_scheduler.h"
11 #include "cc/surfaces/surface_display_output_surface.h" 9 #include "cc/surfaces/surface_display_output_surface.h"
12 #include "cc/surfaces/surface_factory.h" 10 #include "cc/surfaces/surface_factory.h"
13 #include "cc/surfaces/surface_manager.h" 11 #include "cc/surfaces/surface_manager.h"
14 12
15 namespace cc { 13 namespace cc {
16 14
17 OnscreenDisplayClient::OnscreenDisplayClient( 15 OnscreenDisplayClient::OnscreenDisplayClient(
18 scoped_ptr<OutputSurface> output_surface, 16 scoped_ptr<OutputSurface> output_surface,
19 SurfaceManager* manager, 17 SurfaceManager* manager,
20 SharedBitmapManager* bitmap_manager, 18 SharedBitmapManager* bitmap_manager,
21 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager, 19 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager,
22 const RendererSettings& settings, 20 const RendererSettings& settings,
23 scoped_refptr<base::SingleThreadTaskRunner> task_runner) 21 scoped_refptr<base::SingleThreadTaskRunner> task_runner)
24 : output_surface_(output_surface.Pass()), 22 : output_surface_(output_surface.Pass()),
25 display_(new Display(this, 23 display_(new Display(this,
26 manager, 24 manager,
27 bitmap_manager, 25 bitmap_manager,
28 gpu_memory_buffer_manager, 26 gpu_memory_buffer_manager,
29 settings)), 27 settings)),
30 task_runner_(task_runner), 28 task_runner_(task_runner),
31 output_surface_lost_(false) { 29 scheduled_draw_(false),
30 output_surface_lost_(false),
31 deferred_draw_(false),
32 pending_frames_(0),
33 weak_ptr_factory_(this) {
32 } 34 }
33 35
34 OnscreenDisplayClient::~OnscreenDisplayClient() { 36 OnscreenDisplayClient::~OnscreenDisplayClient() {
35 } 37 }
36 38
37 bool OnscreenDisplayClient::Initialize() { 39 bool OnscreenDisplayClient::Initialize() {
38 int max_frames_pending = 40 return display_->Initialize(output_surface_.Pass());
39 output_surface_ ? output_surface_->capabilities().max_frames_pending : 0;
40 if (max_frames_pending <= 0)
41 max_frames_pending = OutputSurface::DEFAULT_MAX_FRAMES_PENDING;
42
43 synthetic_begin_frame_source_ = SyntheticBeginFrameSource::Create(
44 task_runner_.get(), base::TimeTicks(), BeginFrameArgs::DefaultInterval());
45 scheduler_.reset(new DisplayScheduler(display_.get(),
46 synthetic_begin_frame_source_.get(),
47 task_runner_, max_frames_pending));
48 return display_->Initialize(output_surface_.Pass(), scheduler_.get());
49 } 41 }
50 42
51 void OnscreenDisplayClient::CommitVSyncParameters(base::TimeTicks timebase, 43 void OnscreenDisplayClient::CommitVSyncParameters(base::TimeTicks timebase,
52 base::TimeDelta interval) { 44 base::TimeDelta interval) {
53 if (interval == base::TimeDelta()) { 45 surface_display_output_surface_->ReceivedVSyncParameters(timebase, interval);
54 // TODO(brianderson): We should not be receiving 0 intervals. 46 }
55 interval = BeginFrameArgs::DefaultInterval(); 47
48 void OnscreenDisplayClient::DisplayDamaged() {
49 if (scheduled_draw_ || deferred_draw_)
50 return;
51 TRACE_EVENT0("content", "OnscreenDisplayClient::DisplayDamaged");
52 if (pending_frames_ >= display_->GetMaxFramesPending()) {
53 deferred_draw_ = true;
54 } else {
55 ScheduleDraw();
56 } 56 }
57 }
57 58
58 surface_display_output_surface_->ReceivedVSyncParameters(timebase, interval); 59 void OnscreenDisplayClient::ScheduleDraw() {
59 if (synthetic_begin_frame_source_) 60 DCHECK(!deferred_draw_);
60 synthetic_begin_frame_source_->OnUpdateVSyncParameters(timebase, interval); 61 DCHECK(!scheduled_draw_);
62 scheduled_draw_ = true;
63 task_runner_->PostTask(FROM_HERE, base::Bind(&OnscreenDisplayClient::Draw,
64 weak_ptr_factory_.GetWeakPtr()));
61 } 65 }
62 66
63 void OnscreenDisplayClient::OutputSurfaceLost() { 67 void OnscreenDisplayClient::OutputSurfaceLost() {
64 output_surface_lost_ = true; 68 output_surface_lost_ = true;
65 surface_display_output_surface_->DidLoseOutputSurface(); 69 surface_display_output_surface_->DidLoseOutputSurface();
66 } 70 }
67 71
72 void OnscreenDisplayClient::Draw() {
73 TRACE_EVENT0("content", "OnscreenDisplayClient::Draw");
74 if (output_surface_lost_)
75 return;
76 scheduled_draw_ = false;
77 display_->Draw();
78 }
79
80 void OnscreenDisplayClient::DidSwapBuffers() {
81 pending_frames_++;
82 }
83
84 void OnscreenDisplayClient::DidSwapBuffersComplete() {
85 pending_frames_--;
86 if ((pending_frames_ < display_->GetMaxFramesPending()) && deferred_draw_) {
87 deferred_draw_ = false;
88 ScheduleDraw();
89 }
90 }
91
68 void OnscreenDisplayClient::SetMemoryPolicy(const ManagedMemoryPolicy& policy) { 92 void OnscreenDisplayClient::SetMemoryPolicy(const ManagedMemoryPolicy& policy) {
69 surface_display_output_surface_->SetMemoryPolicy(policy); 93 surface_display_output_surface_->SetMemoryPolicy(policy);
70 } 94 }
71 95
72 } // namespace cc 96 } // namespace cc
OLDNEW
« no previous file with comments | « cc/surfaces/onscreen_display_client.h ('k') | mojo/services/surfaces/display_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698