Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1068743003: Revert of Add DisplayScheduler for Surfaces (Closed)

Created:
5 years, 8 months ago by brianderson
Modified:
5 years, 8 months ago
Reviewers:
sunnyps, sky, jbauman, mithro-old
CC:
chromium-reviews, cc-bugs_chromium.org, simonhong, jamesr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add DisplayScheduler for Surfaces (patchset #15 id:280001 of https://codereview.chromium.org/1012853003/) Reason for revert: https://code.google.com/p/chromium/issues/detail?id=476544#c5 Original issue's description: > Add DisplayScheduler for Surfaces > > This uses a SyntheticBeginFrameSource and a simple > BeginFrame + deadline to determine when to draw. > > A simple heuristic based on recent activity is > used to detect currently active surfaces that we > want to wait for. > > Future patches will put this in charge of sending > BeginFrames to surface produces, recovering > producer latency, and replace the heuristic with > something more correct. > > BUG=467750 > > Committed: https://crrev.com/893604464fd906112dd5ff3eec9cc99f6ca645fc > Cr-Commit-Position: refs/heads/master@{#324980} TBR=jbauman@chromium.org,sunnyps@chromium.org,mithro@mithis.com,sky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467750 Committed: https://crrev.com/2954ab1c527d8d5cd6c7dff19e3110412728000f Cr-Commit-Position: refs/heads/master@{#325003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -797 lines) Patch
M cc/cc.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/cc_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M cc/scheduler/scheduler.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/scheduler/scheduler.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/surfaces/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/surfaces/display.h View 5 chunks +4 lines, -10 lines 0 comments Download
M cc/surfaces/display.cc View 8 chunks +20 lines, -40 lines 0 comments Download
M cc/surfaces/display_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
D cc/surfaces/display_scheduler.h View 1 chunk +0 lines, -87 lines 0 comments Download
D cc/surfaces/display_scheduler.cc View 1 chunk +0 lines, -228 lines 0 comments Download
D cc/surfaces/display_scheduler_unittest.cc View 1 chunk +0 lines, -298 lines 0 comments Download
M cc/surfaces/display_unittest.cc View 11 chunks +50 lines, -87 lines 0 comments Download
M cc/surfaces/onscreen_display_client.h View 3 chunks +13 lines, -4 lines 0 comments Download
M cc/surfaces/onscreen_display_client.cc View 3 chunks +44 lines, -20 lines 0 comments Download
M mojo/services/surfaces/display_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/surfaces/display_impl.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M mojo/services/surfaces/surfaces_scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/surfaces/surfaces_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
brianderson
Created Revert of Add DisplayScheduler for Surfaces
5 years, 8 months ago (2015-04-14 05:41:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068743003/1
5 years, 8 months ago (2015-04-14 05:41:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 05:42:46 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 05:43:34 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2954ab1c527d8d5cd6c7dff19e3110412728000f
Cr-Commit-Position: refs/heads/master@{#325003}

Powered by Google App Engine
This is Rietveld 408576698