ozone: Clarify All SurfaceFactoryOzone APIs except for CreateNativePixmap() must be used on the mai…

ozone: Clarify All SurfaceFactoryOzone APIs except for CreateNativePixmap() must be used on the main thread in Gpu process

CreateNativePixmap() can be used in IO thread because IO thread creates GpuMemoryBuffer for low latency.

BUG=472610
Committed: https://crrev.com/95517b8931949391ca3bd5c4426af3c3809ce984
Cr-Commit-Position: refs/heads/master@{#330142}

[dshwang, 2015-04-07 14:25:56]

dongseong.hwang@intel.com changed reviewers:
+ alexst@chromium.org, reveman@chromium.org

[dshwang, 2015-04-07 14:25:57]

alexst@, could you review? This CL adds bunch of thread check in ozone code.
It's extracted from https://codereview.chromium.org/1050923003/

[dshwang, 2015-04-22 08:41:54]

dongseong.hwang@intel.com changed reviewers:
+ spang@chromium.org

[dshwang, 2015-04-22 10:52:58]

spang, alexst, could you review this thread-check CL?

https://codereview.chromium.org/1068723005/diff/1/ui/ozone/public/surface_fac...
File ui/ozone/public/surface_factory_ozone.h (right):

https://codereview.chromium.org/1068723005/diff/1/ui/ozone/public/surface_fac...
ui/ozone/public/surface_factory_ozone.h:135: // It can be called on any thread.
This CL's goal is to clarify all methods must be called in main thread except
for this method.

[spang, 2015-05-07 17:20:45]

https://codereview.chromium.org/1068723005/diff/1/ui/ozone/public/surface_fac...
File ui/ozone/public/surface_factory_ozone.cc (right):

https://codereview.chromium.org/1068723005/diff/1/ui/ozone/public/surface_fac...
ui/ozone/public/surface_factory_ozone.cc:19:
base::LazyInstance<SurfaceFactoryOzone*>::Leaky g_impl =
Please drop these unrelated changes.

I don't think base::LazyInstance is useful here.

https://codereview.chromium.org/1068723005/diff/1/ui/ozone/public/surface_fac...
File ui/ozone/public/surface_factory_ozone.h (right):

https://codereview.chromium.org/1068723005/diff/1/ui/ozone/public/surface_fac...
ui/ozone/public/surface_factory_ozone.h:170: SurfaceFactoryOzone();
This change is not useful. Please don't move code around unnecessarily.

[dshwang, 2015-05-15 18:11:20]

thx for reviewing and sorry for delaying response.
Address your comments. could you review again?

https://codereview.chromium.org/1068723005/diff/1/ui/ozone/public/surface_fac...
File ui/ozone/public/surface_factory_ozone.cc (right):

https://codereview.chromium.org/1068723005/diff/1/ui/ozone/public/surface_fac...
ui/ozone/public/surface_factory_ozone.cc:19:
base::LazyInstance<SurfaceFactoryOzone*>::Leaky g_impl =
On 2015/05/07 17:20:45, spang wrote:
> Please drop these unrelated changes.
> 
> I don't think base::LazyInstance is useful here. 

Done.

https://codereview.chromium.org/1068723005/diff/1/ui/ozone/public/surface_fac...
File ui/ozone/public/surface_factory_ozone.h (right):

https://codereview.chromium.org/1068723005/diff/1/ui/ozone/public/surface_fac...
ui/ozone/public/surface_factory_ozone.h:170: SurfaceFactoryOzone();
On 2015/05/07 17:20:45, spang wrote:
> This change is not useful. Please don't move code around unnecessarily.

Done.

[spang, 2015-05-15 18:12:07]

The CQ bit was checked by spang@chromium.org

[spang, 2015-05-15 18:12:08]

lgtm

[commit-bot: I haz the power, 2015-05-15 18:12:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1068723005/20001

[commit-bot: I haz the power, 2015-05-15 18:33:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-15 18:34:44]

Patchset 2 (id:??) landed as
https://crrev.com/95517b8931949391ca3bd5c4426af3c3809ce984
Cr-Commit-Position: refs/heads/master@{#330142}