ozone: Clarify All SurfaceFactoryOzone APIs except for CreateNativePixmap() must be used on the mai…

ui/ozone/public/surface_factory_ozone.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/public/surface_factory_ozone.h"
 
 #include <stdlib.h>
 
 #include "base/command_line.h"
+#include "base/lazy_instance.h"
 #include "ui/ozone/public/native_pixmap.h"
 #include "ui/ozone/public/surface_ozone_canvas.h"
 #include "ui/ozone/public/surface_ozone_egl.h"
 
 namespace ui {
 
-// static
-SurfaceFactoryOzone* SurfaceFactoryOzone::impl_ = NULL;
+namespace {
+
+base::LazyInstance<SurfaceFactoryOzone*>::Leaky g_impl =

[spang, 2015/05/07 17:20:45]

Please drop these unrelated changes.

I don't think base::LazyInstance is useful here. 

[dshwang, 2015/05/15 18:11:20]

Done.

+    LAZY_INSTANCE_INITIALIZER;
+
+}  // namespace
 
 SurfaceFactoryOzone::SurfaceFactoryOzone() {
-  DCHECK(!impl_) << "There should only be a single SurfaceFactoryOzone.";
-  impl_ = this;
+  DCHECK(!g_impl.Get()) << "There should only be a single SurfaceFactoryOzone.";
+  *g_impl.Pointer() = this;
 }
 
 SurfaceFactoryOzone::~SurfaceFactoryOzone() {
-  DCHECK_EQ(impl_, this);
-  impl_ = NULL;
+  DCHECK_EQ(g_impl.Get(), this);
+  *g_impl.Pointer() = nullptr;
 }
 
 SurfaceFactoryOzone* SurfaceFactoryOzone::GetInstance() {
-  DCHECK(impl_) << "No SurfaceFactoryOzone implementation set.";
-  return impl_;
+  DCHECK(g_impl.Get()) << "No SurfaceFactoryOzone implementation set.";
+  return g_impl.Get();
 }
 
 intptr_t SurfaceFactoryOzone::GetNativeDisplay() {
   return 0;
 }
 
 int SurfaceFactoryOzone::GetDrmFd() {
   return -1;
 }
 
@@ skipping 16 matching lines @@
   return nullptr;
 }
 
 const int32* SurfaceFactoryOzone::GetEGLSurfaceProperties(
     const int32* desired_attributes) {
   return desired_attributes;
 }
 
 ui::OverlayCandidatesOzone* SurfaceFactoryOzone::GetOverlayCandidates(
     gfx::AcceleratedWidget w) {
-  return NULL;
+  return nullptr;
 }
 
 scoped_refptr<ui::NativePixmap> SurfaceFactoryOzone::CreateNativePixmap(
     gfx::AcceleratedWidget widget,
     gfx::Size size,
     BufferFormat format,
     BufferUsage usage) {
-  return NULL;
+  return nullptr;
 }
 
 bool SurfaceFactoryOzone::ScheduleOverlayPlane(
     gfx::AcceleratedWidget widget,
     int plane_z_order,
     gfx::OverlayTransform plane_transform,
     scoped_refptr<NativePixmap> buffer,
     const gfx::Rect& display_bounds,
     const gfx::RectF& crop_rect) {
   return false;
 }
 
 bool SurfaceFactoryOzone::CanShowPrimaryPlaneAsOverlay() {
   return false;
 }
 
 bool SurfaceFactoryOzone::CanCreateNativePixmap(BufferUsage usage) {
   return false;
 }
 
 }  // namespace ui