Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1068723003: Revert of Turn off overapproximation of the weak closure again (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Turn off overapproximation of the weak closure again (patchset #1 id:1 of https://codereview.chromium.org/1050443002/) Reason for revert: this indeed drops the max major gc time considerable, so turn it back on Original issue's description: > Turn off overapproximation of the weak closure again > > As long as we still have to process global handles, the impact is not > yet worthwhile > > BUG=v8:3862 > R=hpayer@chromium.org > LOG=y > > Committed: https://crrev.com/294cdc6aecbd7f76be68217da4b3d35901ebce4b > Cr-Commit-Position: refs/heads/master@{#27570} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3862 Committed: https://crrev.com/a7c1b0a92b603201dbb09547b935db5bb54a6e64 Cr-Commit-Position: refs/heads/master@{#27616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Turn off overapproximation of the weak closure again
5 years, 8 months ago (2015-04-07 09:45:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068723003/1
5 years, 8 months ago (2015-04-07 09:45:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 09:46:02 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 09:46:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7c1b0a92b603201dbb09547b935db5bb54a6e64
Cr-Commit-Position: refs/heads/master@{#27616}

Powered by Google App Engine
This is Rietveld 408576698