src/flag-definitions.h - Issue 1068723003: Revert of Turn off overapproximation of the weak closure again

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/flag-definitions.h

Issue 1068723003: Revert of Turn off overapproximation of the weak closure again (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/flag-definitions.h

diff --git a/src/flag-definitions.h b/src/flag-definitions.h

index b008b8d84b923bd9867f0d1595045ff50da6e42b..42d8ce3cb23e270f20bd47662da8c19f6126a893 100644

--- a/src/flag-definitions.h

+++ b/src/flag-definitions.h

@@ -614,7 +614,7 @@

"old code (required for code flushing)")

DEFINE_BOOL(incremental_marking, true, "use incremental marking")

DEFINE_BOOL(incremental_marking_steps, true, "do incremental marking steps")

-DEFINE_BOOL(overapproximate_weak_closure, false,

+DEFINE_BOOL(overapproximate_weak_closure, true,

"overapproximate weak closer to reduce atomic pause time")

DEFINE_INT(min_progress_during_object_groups_marking, 128,

"keep overapproximating the weak closure as long as we discover at "

« no previous file with comments | « no previous file | no next file » | no next file with comments »