Source/core/dom/DatasetDOMStringMap.h - Issue 106853005: Implement platform deleters per spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/DatasetDOMStringMap.h

Issue 106853005: Implement platform deleters per spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Switch to DeleteResult enum + extend scheme to indexed deleters Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/DatasetDOMStringMap.h

diff --git a/Source/core/dom/DatasetDOMStringMap.h b/Source/core/dom/DatasetDOMStringMap.h

index 9bbd1d09abccd22cfe5041b08c3bbbc1f5374392..7b4177ee3ece5c6a0952c197d7f1ae79d6f4c5d9 100644

--- a/Source/core/dom/DatasetDOMStringMap.h

+++ b/Source/core/dom/DatasetDOMStringMap.h

@@ -48,7 +48,7 @@ public:

virtual String item(const String& name);

virtual bool contains(const String& name);

virtual void setItem(const String& name, const String& value, ExceptionState&);

- virtual void deleteItem(const String& name, ExceptionState&);

+ virtual bool deleteItem(const String& name);

virtual Element* element() { return m_element; }