Source/bindings/scripts/code_generator_v8.pm - Issue 106853005: Implement platform deleters per spec.

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 106853005: Implement platform deleters per spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Switch to DeleteResult enum + extend scheme to indexed deleters Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/storage/domstorage/localstorage/delete-removal-expected.txt ('k') | Source/bindings/tests/results/V8TestEventTarget.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/scripts/code_generator_v8.pm

diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm

index a0a5565bfee9821123c4808b9a22969be0671c31..69dc36afe6d5348f0c80144da570d994afb6b8ab 100644

--- a/Source/bindings/scripts/code_generator_v8.pm

+++ b/Source/bindings/scripts/code_generator_v8.pm

@@ -4049,12 +4049,13 @@ sub GenerateImplementationIndexedPropertyDeleter

$code .= " ExceptionState exceptionState(info.Holder(), info.GetIsolate());\n";

$extraArguments = ", exceptionState";

}

- $code .= " bool result = collection->${methodName}(index$extraArguments);\n";

+ $code .= " DeleteResult result = collection->${methodName}(index$extraArguments);\n";

if ($raisesExceptions) {

$code .= " if (exceptionState.throwIfNeeded())\n";

$code .= " return;\n";

}

- $code .= " return v8SetReturnValueBool(info, result);\n";

+ $code .= " if (result != DeleteUnknownProperty)\n";

+ $code .= " return v8SetReturnValueBool(info, result == DeleteSuccess);\n";

$code .= "}\n\n";

$implementation{nameSpaceInternal}->add($code);

}

@@ -4076,14 +4077,15 @@ sub GenerateImplementationNamedPropertyDeleter

my $extraArguments = "";

if ($raisesExceptions) {

$code .= " ExceptionState exceptionState(info.Holder(), info.GetIsolate());\n";

- $extraArguments = ", exceptionState";

+ $extraArguments .= ", exceptionState";

}

- $code .= " bool result = collection->${methodName}(propertyName$extraArguments);\n";

+ $code .= " DeleteResult result = collection->${methodName}(propertyName$extraArguments);\n";

if ($raisesExceptions) {

$code .= " if (exceptionState.throwIfNeeded())\n";

$code .= " return;\n";

}

- $code .= " return v8SetReturnValueBool(info, result);\n";

+ $code .= " if (result != DeleteUnknownProperty)\n";

+ $code .= " return v8SetReturnValueBool(info, result == DeleteSuccess);\n";

jsbell 2013/12/18 00:49:34 Sorry if I'm missing something, but doesn't this i

sof 2013/12/18 06:17:00 Yes, exactly that. The v8 interceptor code that's

$code .= "}\n\n";

$implementation{nameSpaceInternal}->add($code);

}