Source/bindings/v8/V8Binding.h - Issue 106853005: Implement platform deleters per spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8Binding.h

Issue 106853005: Implement platform deleters per spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Switch to DeleteResult enum + extend scheme to indexed deleters Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8Binding.h

diff --git a/Source/bindings/v8/V8Binding.h b/Source/bindings/v8/V8Binding.h

index 48200a2fdd00b7ced8581c2ba83e053e005e444a..68a4cd319c782ec5f584bef629b5a29c968ab695 100644

--- a/Source/bindings/v8/V8Binding.h

+++ b/Source/bindings/v8/V8Binding.h

@@ -696,6 +696,14 @@ namespace WebCore {

// Each specialized implementation will be generated.

template<typename T>

v8::Handle<v8::Value> toV8NoInline(T* impl, v8::Handle<v8::Object> creationContext, v8::Isolate*);

+ // Result values for platform object 'deleter' methods,

+ // http://www.w3.org/TR/WebIDL/#delete

+ enum DeleteResult {

+ DeleteSuccess,

+ DeleteReject,

+ DeleteUnknownProperty

+ };

} // namespace WebCore

#endif // V8Binding_h