Implement platform deleters per spec.

Source/bindings/scripts/code_generator_v8.pm

 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
 # Copyright (C) 2006 Apple Computer, Inc.
 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
 # Copyright (C) 2012 Ericsson AB. All rights reserved.
@@ skipping 4031 matching lines @@
     my $raisesExceptions = $indexedDeleterFunction->extendedAttributes->{"RaisesException"};
 
     my $code = "static void indexedPropertyDeleter(unsigned index, const v8::PropertyCallbackInfo<v8::Boolean>& info)\n";
     $code .= "{\n";
     $code .= "    ${implClassName}* collection = ${v8ClassName}::toNative(info.Holder());\n";
     my $extraArguments = "";
     if ($raisesExceptions) {
         $code .= "    ExceptionState exceptionState(info.Holder(), info.GetIsolate());\n";
         $extraArguments = ", exceptionState";
     }
-    $code .= "    bool result = collection->${methodName}(index$extraArguments);\n";
+    $code .= "    DeleteResult result = collection->${methodName}(index$extraArguments);\n";
     if ($raisesExceptions) {
         $code .= "    if (exceptionState.throwIfNeeded())\n";
         $code .= "        return;\n";
     }
-    $code .= "    return v8SetReturnValueBool(info, result);\n";
+    $code .= "    if (result != DeleteUnknownProperty)\n";
+    $code .= "        return v8SetReturnValueBool(info, result == DeleteSuccess);\n";
     $code .= "}\n\n";
     $implementation{nameSpaceInternal}->add($code);
 }
 
 sub GenerateImplementationNamedPropertyDeleter
 {
     my $interface = shift;
     my $namedDeleterFunction = shift;
     my $implClassName = GetImplName($interface);
     my $v8ClassName = GetV8ClassName($interface);
     my $methodName = GetImplName($namedDeleterFunction);
 
     my $raisesExceptions = $namedDeleterFunction->extendedAttributes->{"RaisesException"};
 
     my $code = "static void namedPropertyDeleter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Boolean>& info)\n";
     $code .= "{\n";
     $code .= "    ${implClassName}* collection = ${v8ClassName}::toNative(info.Holder());\n";
     $code .= "    AtomicString propertyName = toCoreAtomicString(name);\n";
     my $extraArguments = "";
     if ($raisesExceptions) {
         $code .= "    ExceptionState exceptionState(info.Holder(), info.GetIsolate());\n";
-        $extraArguments = ", exceptionState";
+        $extraArguments .= ", exceptionState";
     }
-    $code .= "    bool result = collection->${methodName}(propertyName$extraArguments);\n";
+    $code .= "    DeleteResult result = collection->${methodName}(propertyName$extraArguments);\n";
     if ($raisesExceptions) {
         $code .= "    if (exceptionState.throwIfNeeded())\n";
         $code .= "        return;\n";
     }
-    $code .= "    return v8SetReturnValueBool(info, result);\n";
+    $code .= "    if (result != DeleteUnknownProperty)\n";
+    $code .= "        return v8SetReturnValueBool(info, result == DeleteSuccess);\n";

[jsbell, 2013/12/18 00:49:34]

Sorry if I'm missing something, but doesn't this imply that the deleter may now
return true (if result == DeleteSuccess), false (if result == DeleteReject), or
undefined (if result == DeleteUnknownProperty)?

[sof, 2013/12/18 06:17:00]

Yes, exactly that.

The v8 interceptor code that's calling will interpret undefined as the property
being unknown to the interceptor layer, and fall into accessing the native
property instead. See JSObject::DeletePropertyWithInterceptor().

     $code .= "}\n\n";
     $implementation{nameSpaceInternal}->add($code);
 }
 
 sub GenerateImplementationNamedPropertyEnumerator
 {
     my $interface = shift;
     my $implClassName = GetImplName($interface);
     my $v8ClassName = GetV8ClassName($interface);
 
@@ skipping 2240 matching lines @@
 
     return 1 if ExtendedAttributeContains($interface->extendedAttributes->{"Custom"}, "ToV8");
     return 1 if ExtendedAttributeContains($interface->extendedAttributes->{"Custom"}, "Wrap");
     return 1 if $interface->extendedAttributes->{"SpecialWrapFor"};
     return 1 if InheritsInterface($interface, "Document");
 
     return 0;
 }
 
 1;