Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1068463004: Set willReadFragmentPosition on XP when doing a DstCopy. (Closed)

Created:
5 years, 8 months ago by egdaniel
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Set willReadFragmentPosition on XP when doing a DstCopy. BUG=472872 Committed: https://skia.googlesource.com/skia/+/060a52c21065092154199fb7f51944339d602642

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/gpu/GrPipeline.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/GrXferProcessor.cpp View 1 chunk +1 line, -0 lines 3 comments Download

Messages

Total messages: 10 (2 generated)
egdaniel
5 years, 8 months ago (2015-04-07 13:32:56 UTC) #2
egdaniel
5 years, 8 months ago (2015-04-07 13:32:57 UTC) #3
robertphillips
https://codereview.chromium.org/1068463004/diff/1/src/gpu/GrXferProcessor.cpp File src/gpu/GrXferProcessor.cpp (right): https://codereview.chromium.org/1068463004/diff/1/src/gpu/GrXferProcessor.cpp#newcode20 src/gpu/GrXferProcessor.cpp:20: this->addTextureAccess(&fDstCopy); So we always read the frag position?
5 years, 8 months ago (2015-04-07 14:12:58 UTC) #4
egdaniel
https://codereview.chromium.org/1068463004/diff/1/src/gpu/GrXferProcessor.cpp File src/gpu/GrXferProcessor.cpp (right): https://codereview.chromium.org/1068463004/diff/1/src/gpu/GrXferProcessor.cpp#newcode20 src/gpu/GrXferProcessor.cpp:20: this->addTextureAccess(&fDstCopy); On 2015/04/07 14:12:58, robertphillips wrote: > So we ...
5 years, 8 months ago (2015-04-07 14:18:12 UTC) #5
bsalomon
https://codereview.chromium.org/1068463004/diff/1/src/gpu/GrXferProcessor.cpp File src/gpu/GrXferProcessor.cpp (right): https://codereview.chromium.org/1068463004/diff/1/src/gpu/GrXferProcessor.cpp#newcode20 src/gpu/GrXferProcessor.cpp:20: this->addTextureAccess(&fDstCopy); On 2015/04/07 14:12:58, robertphillips wrote: > So we ...
5 years, 8 months ago (2015-04-07 14:18:40 UTC) #6
robertphillips
lgtm
5 years, 8 months ago (2015-04-07 14:25:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068463004/1
5 years, 8 months ago (2015-04-07 14:25:36 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 14:31:15 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/060a52c21065092154199fb7f51944339d602642

Powered by Google App Engine
This is Rietveld 408576698