Issue 1068383003: Revert of Rearrange SkRecord with small N in mind

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1068383003: Revert of Rearrange SkRecord with small N in mind (Closed)

Created:
5 years, 8 months ago by mtklein

Modified:
5 years, 8 months ago

Reviewers:
mtklein_C, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Rearrange SkRecord with small N in mind (patchset #8 id:120001 of https://codereview.chromium.org/1061783002/) Reason for revert: https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug/builds/149/steps/dm/logs/stdio Original issue's description: > Rearrange SkRecord with small N in mind > > This rearranges the record pointers and types so they can go in a single array, then preallocates some space for them and for the SkVarAlloc. > > picture_overhead_draw bench drops from ~1000ns to 500-600ns, with no effect on picture_overhead_nodraw. > > I don't see any significant effect on large picture recording times from our .skps. > > BUG=chromium:470553 > > Committed: https://skia.googlesource.com/skia/+/e2dd9408cd711777afaa9410427fb0d761ab004a TBR=reed@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:470553 Committed: https://skia.googlesource.com/skia/+/35f55764b81390a085fb90f624082c196fbd6229

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -80 lines)			Patch
M	src/core/SkRecord.h	View	11 chunks	+86 lines, -46 lines	0 comments	Download
M	src/core/SkRecord.cpp	View	2 chunks	+3 lines, -10 lines	0 comments	Download
M	src/core/SkVarAlloc.h	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	src/core/SkVarAlloc.cpp	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	tests/PictureTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of Rearrange SkRecord with small N in mind

5 years, 8 months ago (2015-04-08 21:09:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068383003/1

5 years, 8 months ago (2015-04-08 21:09:36 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-08 21:09:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/35f55764b81390a085fb90f624082c196fbd6229