Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: pkg/compiler/lib/src/cps_ir/redundant_phi.dart

Issue 1068243002: Overhaul tree IR visitor and rename IR classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/redundant_phi.dart
diff --git a/pkg/compiler/lib/src/cps_ir/redundant_phi.dart b/pkg/compiler/lib/src/cps_ir/redundant_phi.dart
index b61e7854b7a4a7d8c5e7c1635bb19073789a4744..05bc958d6b5234c519ea8e449547353b6d49fd6e 100644
--- a/pkg/compiler/lib/src/cps_ir/redundant_phi.dart
+++ b/pkg/compiler/lib/src/cps_ir/redundant_phi.dart
@@ -12,13 +12,14 @@ part of dart2js.cps_ir.optimizers;
/// (except for feedback). Redundant parameters are removed from the
/// continuation signature, all invocations, and replaced within the
/// continuation body.
-class RedundantPhiEliminator extends RecursiveVisitor with PassMixin {
+class RedundantPhiEliminator extends RecursiveVisitor implements Pass {
String get passName => 'Redundant phi elimination';
final Set<Continuation> workSet = new Set<Continuation>();
@override
- void rewriteExecutableDefinition(final ExecutableDefinition root) {
+ void rewrite(final RootNode root) {
Kevin Millikin (Google) 2015/04/08 15:10:15 final? Really?
asgerf 2015/04/09 09:58:23 I guess someone wanted to be extra safe. Removed
+ if (root.isEmpty) return;
// Set all parent pointers.
new ParentVisitor().visit(root);

Powered by Google App Engine
This is Rietveld 408576698