Overhaul tree IR visitor and rename IR classes.

pkg/compiler/lib/src/dart_backend/backend.dart

Index: pkg/compiler/lib/src/dart_backend/backend.dart
diff --git a/pkg/compiler/lib/src/dart_backend/backend.dart b/pkg/compiler/lib/src/dart_backend/backend.dart
index f84157b5b6f9eb6416f7b0b467df9cd888185f64..639ef287d3056acc5bd02255b81c25e95bdaece4 100644
--- a/pkg/compiler/lib/src/dart_backend/backend.dart
+++ b/pkg/compiler/lib/src/dart_backend/backend.dart
@@ -131,12 +131,12 @@ class DartBackend extends Backend {
 
   void codegen(CodegenWorkItem work) { }
 
-  static bool checkTreeIntegrity(tree_ir.ExecutableDefinition node) {
+  static bool checkTreeIntegrity(tree_ir.RootNode node) {
     new CheckTreeIntegrity().check(node);
     return true; // So this can be used from assert().
   }
 
-  static bool checkCpsIntegrity(cps_ir.ExecutableDefinition node) {
+  static bool checkCpsIntegrity(cps_ir.RootNode node) {
     new CheckCpsIntegrity().check(node);
     return true; // So this can be used from assert().
   }
@@ -145,7 +145,7 @@ class DartBackend extends Backend {
   static ElementAst createElementAst(
        ElementAstCreationContext context,
        Element element,
-       cps_ir.ExecutableDefinition cpsDefinition) {
+       cps_ir.RootNode cpsDefinition) {

[Kevin Millikin (Google), 2015/04/08 15:10:15]

cpsDefinition ==> cpsRoot?

[asgerf, 2015/04/09 09:58:23]

Absolutely.

     context.traceCompilation(element.name);
     context.traceGraph('CPS builder', cpsDefinition);
     assert(checkCpsIntegrity(cpsDefinition));
@@ -170,7 +170,7 @@ class DartBackend extends Backend {
 
     tree_builder.Builder builder =
         new tree_builder.Builder(context.internalError);
-    tree_ir.ExecutableDefinition treeDefinition = builder.build(cpsDefinition);
+    tree_ir.RootNode treeDefinition = builder.build(cpsDefinition);

[Kevin Millikin (Google), 2015/04/08 15:10:15]

treeDefinition ==> treeRoot?

[asgerf, 2015/04/09 09:58:23]

Done.

     assert(treeDefinition != null);
     context.traceGraph('Tree builder', treeDefinition);
     assert(checkTreeIntegrity(treeDefinition));
@@ -192,7 +192,7 @@ class DartBackend extends Backend {
     context.traceGraph('Unshadow parameters', treeDefinition);
 
     TreeElementMapping treeElements = new TreeElementMapping(element);
-    backend_ast.ExecutableDefinition backendAst =
+    backend_ast.RootNode backendAst =
         backend_ast_emitter.emit(treeDefinition);
     Node frontend_ast = backend2frontend.emit(treeElements, backendAst);
     return new ElementAst(frontend_ast, treeElements);
@@ -220,7 +220,7 @@ class DartBackend extends Backend {
         return new ElementAst(element.resolvedAst.node,
                               element.resolvedAst.elements);
       } else {
-        cps_ir.ExecutableDefinition definition =
+        cps_ir.RootNode definition =

[Kevin Millikin (Google), 2015/04/08 15:10:15]

definition ==> root or node.

[asgerf, 2015/04/09 09:58:23]

Went with irNode since there's also AST nodes flying around here.

             compiler.irBuilder.getIr(element);
         return createElementAst(context, element, definition);
       }