Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 1068073002: drop 'orphan' property (Closed)

Created:
5 years, 8 months ago by Hixie
Modified:
5 years, 8 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

drop 'orphan' property, since it's for paged media and we don't support paged media any more R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7e3fa351ab697f42338a76b2c665fbc105a21ac0

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix ojan's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -44 lines) Patch
M sky/engine/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/animation/css/CSSPropertyEquality.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/css/CSSProperties.in View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/StylePropertySet.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/editing/EditingStyle.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 3 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareInheritedData.h View 1 2 chunks +5 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareInheritedData.cpp View 1 6 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ojan
A little more change description please. Someone with less context ought to be able to ...
5 years, 8 months ago (2015-04-08 00:05:44 UTC) #2
ojan
lgtm
5 years, 8 months ago (2015-04-08 00:05:55 UTC) #3
Hixie
On 2015/04/08 00:05:44, ojan wrote: > We should either update the size or delete the ...
5 years, 8 months ago (2015-04-09 15:51:06 UTC) #4
Hixie
5 years, 8 months ago (2015-04-09 16:24:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7e3fa351ab697f42338a76b2c665fbc105a21ac0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698