sky/engine/core/css/resolver/AnimatedStyleBuilder.cpp - Issue 1068073002: drop 'orphan' property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/css/resolver/AnimatedStyleBuilder.cpp

Issue 1068073002: drop 'orphan' property (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: fix ojan's comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/css/resolver/AnimatedStyleBuilder.cpp

diff --git a/sky/engine/core/css/resolver/AnimatedStyleBuilder.cpp b/sky/engine/core/css/resolver/AnimatedStyleBuilder.cpp

index 9f7ea7f53f227d00e9e74b22413444f9c1371f54..67f73ae00014cf89ebaf392c083bef42c24b077b 100644

--- a/sky/engine/core/css/resolver/AnimatedStyleBuilder.cpp

+++ b/sky/engine/core/css/resolver/AnimatedStyleBuilder.cpp

@@ -384,9 +384,6 @@ void AnimatedStyleBuilder::applyProperty(CSSPropertyID property, StyleResolverSt

// Avoiding a value of 1 forces a layer to be created.

style->setOpacity(clampTo<float>(toAnimatableDouble(value)->toDouble(), 0, nextafterf(1, 0)));

return;

- case CSSPropertyOrphans:

- style->setOrphans(animatableValueRoundClampTo<unsigned short>(value, 1));

- return;

case CSSPropertyOutlineColor:

style->setOutlineColor(toAnimatableColor(value)->color());

return;