Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1067883002: [Telemetry] Add the feature of narrowing down the "gesture" interaction record to TBM. (Closed)

Created:
5 years, 8 months ago by nednguyen
Modified:
5 years, 8 months ago
Reviewers:
eakuefner, nduca
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Add the feature of narrowing down the "gesture" interaction record to TBM. Move smooth_gesture_util from tools/perf/ to tools/telemetry/telemetry/web_perf/ BUG=468061 Committed: https://crrev.com/c961e52a9cd28b637100281203b46c95299dbf0a Cr-Commit-Position: refs/heads/master@{#324323}

Patch Set 1 #

Patch Set 2 : Fix import statement in timeline_controller #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -204 lines) Patch
D tools/perf/measurements/smooth_gesture_util.py View 1 chunk +0 lines, -37 lines 0 comments Download
D tools/perf/measurements/smooth_gesture_util_unittest.py View 1 chunk +0 lines, -161 lines 0 comments Download
M tools/perf/measurements/smoothness_controller.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/measurements/timeline_controller.py View 1 1 chunk +1 line, -2 lines 0 comments Download
A + tools/telemetry/telemetry/web_perf/smooth_gesture_util.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement.py View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py View 3 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
nednguyen
5 years, 8 months ago (2015-04-07 17:23:49 UTC) #2
nduca
lgtm
5 years, 8 months ago (2015-04-08 16:30:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067883002/1
5 years, 8 months ago (2015-04-08 16:34:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067883002/20001
5 years, 8 months ago (2015-04-08 20:37:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-09 00:56:46 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 00:58:31 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c961e52a9cd28b637100281203b46c95299dbf0a
Cr-Commit-Position: refs/heads/master@{#324323}

Powered by Google App Engine
This is Rietveld 408576698