tools/telemetry/telemetry/web_perf/timeline_based_measurement.py - Issue 1067883002: [Telemetry] Add the feature of narrowing down the "gesture" interaction record to TBM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

Issue 1067883002: [Telemetry] Add the feature of narrowing down the "gesture" interaction record to TBM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix import statement in timeline_controller Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py ('k') | tools/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

index cf7aeb507848409022cd8ed18ca6194b2cb1e3c2..89da732ac15e7ce43b8a34f7f52d612bffe7b1a8 100644

--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

@@ -12,6 +12,7 @@ from telemetry.web_perf.metrics import layout

from telemetry.web_perf.metrics import responsiveness_metric

from telemetry.web_perf.metrics import smoothness

from telemetry.web_perf import timeline_interaction_record as tir_module

+from telemetry.web_perf import smooth_gesture_util

# TimelineBasedMeasurement considers all instrumentation as producing a single

# timeline. But, depending on the amount of instrumentation that is enabled,

@@ -68,6 +69,11 @@ def _GetRendererThreadsToInteractionRecordsMap(model):

# TODO(nduca): Add support for page-load interaction record.

if tir_module.IsTimelineInteractionRecord(event.name):

interaction = tir_module.TimelineInteractionRecord.FromAsyncEvent(event)

+ # Adjust the interaction record to match the synthetic gesture

+ # controller if needed.

+ interaction = (

+ smooth_gesture_util.GetAdjustedInteractionIfContainGesture(

+ model, interaction))

threads_to_records_map[curr_thread].append(interaction)

if interaction.label in interaction_labels_of_previous_threads:

raise InvalidInteractions(