Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1067763004: Remove the deprecated use_nss and USE_NSS flags. (Closed)

Created:
5 years, 8 months ago by davidben
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@use-nss-certs-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the deprecated use_nss and USE_NSS flags. This was separated out from https://codereview.chromium.org/1085923002/ and https://codereview.chromium.org/1082123003/ so that, if needbe, a revert is small. BUG=462040 Committed: https://crrev.com/745f7ca5062cb971453b77eb4b2008eade64ff5e Cr-Commit-Position: refs/heads/master@{#325888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -20 lines) Patch
M build/common.gypi View 3 chunks +1 line, -13 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
thakis was the one who suggested the split, but it seems he's now going to ...
5 years, 8 months ago (2015-04-16 22:32:07 UTC) #2
Dirk Pranke
lgtm
5 years, 8 months ago (2015-04-16 22:36:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067763004/1
5 years, 8 months ago (2015-04-20 16:16:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-20 18:59:31 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 19:00:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/745f7ca5062cb971453b77eb4b2008eade64ff5e
Cr-Commit-Position: refs/heads/master@{#325888}

Powered by Google App Engine
This is Rietveld 408576698