Source/bindings/core/v8/ScriptState.cpp - Issue 1067763002: bindings: Use Maybe version of Get in bindings/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptState.cpp

Issue 1067763002: bindings: Use Maybe version of Get in bindings/ (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/ScriptState.cpp

diff --git a/Source/bindings/core/v8/ScriptState.cpp b/Source/bindings/core/v8/ScriptState.cpp

index 3de3de91fab7a2c8e7ef9fec6e6060c9cfb634aa..0ab6195b7681f5498fd539f657d11112dfad3a89 100644

--- a/Source/bindings/core/v8/ScriptState.cpp

+++ b/Source/bindings/core/v8/ScriptState.cpp

@@ -88,7 +88,9 @@ void ScriptState::setEvalEnabled(bool enabled)

ScriptValue ScriptState::getFromGlobalObject(const char* name)

{

v8::HandleScope handleScope(m_isolate);

- v8::Local<v8::Value> v8Value = context()->Global()->Get(v8AtomicString(isolate(), name));

+ v8::Local<v8::Value> v8Value;

+ if (!context()->Global()->Get(context(), v8AtomicString(isolate(), name)).ToLocal(&v8Value))

+ return ScriptValue();

return ScriptValue(this, v8Value);

}