Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: Source/bindings/core/v8/ScriptFunctionCall.cpp

Issue 1067763002: bindings: Use Maybe version of Get in bindings/ (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/ScriptFunctionCall.cpp
diff --git a/Source/bindings/core/v8/ScriptFunctionCall.cpp b/Source/bindings/core/v8/ScriptFunctionCall.cpp
index 0227be6dcb393365b3f14a395e28707435002d72..63e95db99f4f34d3d303931935c3c31a0ff1cfd5 100644
--- a/Source/bindings/core/v8/ScriptFunctionCall.cpp
+++ b/Source/bindings/core/v8/ScriptFunctionCall.cpp
@@ -105,8 +105,8 @@ ScriptValue ScriptFunctionCall::call(bool& hadException, bool reportExceptions)
tryCatch.SetVerbose(reportExceptions);
v8::Local<v8::Object> thisObject = v8::Local<v8::Object>::Cast(m_thisObject.v8Value());
- v8::Local<v8::Value> value = thisObject->Get(v8String(m_scriptState->isolate(), m_name));
- if (tryCatch.HasCaught()) {
+ v8::Local<v8::Value> value;
+ if (!thisObject->Get(m_scriptState->context(), v8String(m_scriptState->isolate(), m_name)).ToLocal(&value)) {
hadException = true;
return ScriptValue();
}

Powered by Google App Engine
This is Rietveld 408576698