Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Issue 106763010: Add support for new-style trybot specifications to git_cl.py. (Closed)

Created:
7 years ago by ghost stip (do not use)
Modified:
7 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Add support for new-style trybot specifications to git_cl.py. BUG=278554 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=241629

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M git_cl.py View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
ghost stip (do not use)
ptal I couldn't find an appropriate place to put a unit test (git_cl_test.py doesn't seem ...
7 years ago (2013-12-18 19:57:00 UTC) #1
M-A Ruel
On 2013/12/18 19:57:00, stip wrote: > ptal > > I couldn't find an appropriate place ...
7 years ago (2013-12-18 20:01:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stip@chromium.org/106763010/1
7 years ago (2013-12-18 20:01:37 UTC) #3
commit-bot: I haz the power
Presubmit check for 106763010-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years ago (2013-12-18 20:03:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stip@chromium.org/106763010/1
7 years ago (2013-12-18 20:05:24 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-18 20:07:45 UTC) #6
Message was sent while issue was closed.
Change committed as 241629

Powered by Google App Engine
This is Rietveld 408576698