Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: git_cl.py

Issue 106763010: Add support for new-style trybot specifications to git_cl.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 4ef4c4630a8e4008474492620af64cc2b34aa648..d01c354169f691a96da77c650b10abea18b5edf0 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -2097,7 +2097,10 @@ def CMDtry(parser, args):
parser.error('No default try builder to try, use --bot')
builders_and_tests = {}
- for bot in options.bot:
+ old_style = filter(lambda x: isinstance(x, basestring), options.bot)
+ new_style = filter(lambda x: isinstance(x, tuple), options.bot)
+
+ for bot in old_style:
if ':' in bot:
builder, tests = bot.split(':', 1)
builders_and_tests.setdefault(builder, []).extend(tests.split(','))
@@ -2106,6 +2109,9 @@ def CMDtry(parser, args):
else:
builders_and_tests.setdefault(bot, []).append('defaulttests')
+ for bot, tests in new_style:
+ builders_and_tests.setdefault(bot, []).extend(tests)
+
if options.testfilter:
forced_tests = sum((t.split(',') for t in options.testfilter), [])
builders_and_tests = dict(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698