Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1067573003: VectorICs: megamorphic keyed loads in crankshaft don't need a vector. (Closed)

Created:
5 years, 8 months ago by mvstanton
Modified:
5 years, 8 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

VectorICs: megamorphic keyed loads in crankshaft don't need a vector. They are content with a dummy vector, as MISSES won't result in changing the real vector/slot at all. BUG= Committed: https://crrev.com/c8e4d57d3b3036a05902f5b916cb5d853a57393c Cr-Commit-Position: refs/heads/master@{#27788}

Patch Set 1 #

Patch Set 2 : Patch One. #

Patch Set 3 : Ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -30 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/code-factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +8 lines, -21 lines 0 comments Download
M src/hydrogen-instructions.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
mvstanton
Hi Dan, here is the CL we discussed. Uploading ports...
5 years, 8 months ago (2015-04-13 13:15:33 UTC) #2
dcarney
lgtm, assuming you always want MEGAMORPHIC in the keyed case
5 years, 8 months ago (2015-04-13 13:19:38 UTC) #3
mvstanton
Thx! Yep, for now I do. Allowing learning to occur in other cases will mean ...
5 years, 8 months ago (2015-04-13 13:48:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067573003/40001
5 years, 8 months ago (2015-04-13 13:49:08 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-13 13:50:37 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/c8e4d57d3b3036a05902f5b916cb5d853a57393c Cr-Commit-Position: refs/heads/master@{#27788}
5 years, 8 months ago (2015-04-13 13:50:45 UTC) #8
Michael Achenbach
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1060263003/ by machenbach@chromium.org. ...
5 years, 8 months ago (2015-04-13 16:18:57 UTC) #9
Michael Achenbach
On 2015/04/13 16:18:57, Michael Achenbach wrote: > A revert of this CL (patchset #3 id:40001) ...
5 years, 8 months ago (2015-04-13 17:46:53 UTC) #10
mvstanton
5 years, 8 months ago (2015-04-13 18:09:13 UTC) #11
Message was sent while issue was closed.
Yep, thanks for checking it out Michael, I'll have a look on Windows tomorrow...

Powered by Google App Engine
This is Rietveld 408576698