src/ia32/lithium-codegen-ia32.cc - Issue 1067573003: VectorICs: megamorphic keyed loads in crankshaft don't need a vector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 1067573003: VectorICs: megamorphic keyed loads in crankshaft don't need a vector. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Ports. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index 72bb270e7a6fcfe384da3579b12a989e721b9cd2..12a3cb862d6c90ea5063a47b068764cb28cfabcc 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -3235,7 +3235,7 @@ void LCodeGen::DoLoadKeyedGeneric(LLoadKeyedGeneric* instr) {

DCHECK(ToRegister(instr->object()).is(LoadDescriptor::ReceiverRegister()));

DCHECK(ToRegister(instr->key()).is(LoadDescriptor::NameRegister()));

- if (FLAG_vector_ics) {

+ if (instr->hydrogen()->HasVectorAndSlot()) {

EmitVectorLoadICRegisters<LLoadKeyedGeneric>(instr);

}

« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ic/ic.cc » ('j') | no next file with comments »