Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: lib/devc.dart

Issue 1067553004: Factor out reporting from rules (Closed) Base URL: git@github.com:dart-lang/dart-dev-compiler.git@master
Patch Set: Change set/get pair to field Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/src/checker/checker.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/devc.dart
diff --git a/lib/devc.dart b/lib/devc.dart
index ca0e55b8ca81341b6747a468a73017f1f184f62a..27f07028323570550324767ce0cc491877716923 100644
--- a/lib/devc.dart
+++ b/lib/devc.dart
@@ -68,8 +68,8 @@ class Compiler {
: new LogReporter(options.useColors);
}
var graph = new SourceGraph(resolver.context, reporter, options);
- var rules = new RestrictedRules(resolver.context.typeProvider, reporter,
- options: options);
+ var rules =
+ new RestrictedRules(resolver.context.typeProvider, options: options);
var checker = new CodeChecker(rules, reporter, options);
var inputFile = options.entryPointFile;
var uri = inputFile.startsWith('dart:') || inputFile.startsWith('package:')
@@ -177,7 +177,7 @@ class Compiler {
_reporter.enterSource(unitSource);
// TODO(sigmund): integrate analyzer errors with static-info (issue #6).
failureInLib = _resolver.logErrors(unitSource, _reporter) || failureInLib;
- unit.visitChildren(_checker);
+ _checker.visitCompilationUnit(unit);
if (_checker.failure) failureInLib = true;
_reporter.leaveSource();
}
@@ -187,7 +187,7 @@ class Compiler {
}
for (var cg in _generators) {
- var hash = cg.generateLibrary(libraryUnit, current, _reporter);
+ var hash = cg.generateLibrary(libraryUnit, current);
if (_hashing) node.cachingHash = hash;
}
_reporter.leaveLibrary();
« no previous file with comments | « no previous file | lib/src/checker/checker.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698