Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1067173003: Remove mojo:: part of mojo::shell:: nested namespace in //shell. (Closed)

Created:
5 years, 8 months ago by viettrungluu
Modified:
5 years, 8 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove mojo:: part of mojo::shell:: nested namespace in //shell. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bd07e3aa605626017058a02c50ffbe267b81aef3

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+525 lines, -629 lines) Patch
M services/window_manager/window_manager_api_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/android_handler.h View 2 chunks +11 lines, -11 lines 0 comments Download
M shell/android/android_handler.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M shell/android/android_handler_loader.h View 2 chunks +4 lines, -5 lines 0 comments Download
M shell/android/android_handler_loader.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M shell/android/apk/src/org/chromium/mojo/shell/AndroidHandler.java View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/apk/src/org/chromium/mojo/shell/Bootstrap.java View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/apk/src/org/chromium/mojo/shell/IntentReceiverRegistry.java View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/apk/src/org/chromium/mojo/shell/Keyboard.java View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/apk/src/org/chromium/mojo/shell/ShellMain.java View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/background_application_loader.h View 4 chunks +4 lines, -5 lines 0 comments Download
M shell/android/background_application_loader.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M shell/android/background_application_loader_unittest.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M shell/android/bootstrap.cc View 2 chunks +1 line, -3 lines 0 comments Download
M shell/android/intent_receiver_manager_factory.h View 1 chunk +6 lines, -6 lines 0 comments Download
M shell/android/intent_receiver_manager_factory.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M shell/android/intent_receiver_manager_impl.h View 1 chunk +3 lines, -4 lines 0 comments Download
M shell/android/intent_receiver_manager_impl.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M shell/android/keyboard_impl.h View 1 chunk +4 lines, -6 lines 0 comments Download
M shell/android/keyboard_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download
M shell/android/library_loader.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M shell/android/main.h View 1 chunk +0 lines, -2 lines 0 comments Download
M shell/android/main.cc View 3 chunks +1 line, -3 lines 0 comments Download
M shell/android/native_viewport_application_loader.h View 1 chunk +23 lines, -21 lines 0 comments Download
M shell/android/native_viewport_application_loader.cc View 2 chunks +13 lines, -14 lines 0 comments Download
M shell/android/run_android_application_function.h View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/android/tests/src/org/chromium/mojo/shell/ShellTestBase.java View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/ui_application_loader_android.h View 4 chunks +6 lines, -6 lines 0 comments Download
M shell/android/ui_application_loader_android.cc View 4 chunks +2 lines, -4 lines 0 comments Download
M shell/application_manager/application_loader.h View 2 chunks +4 lines, -4 lines 0 comments Download
M shell/application_manager/application_manager.h View 6 chunks +47 lines, -44 lines 0 comments Download
M shell/application_manager/application_manager.cc View 13 chunks +37 lines, -37 lines 0 comments Download
M shell/application_manager/application_manager_unittest.cc View 13 chunks +59 lines, -52 lines 1 comment Download
M shell/application_manager/data_pipe_peek.h View 2 chunks +2 lines, -4 lines 0 comments Download
M shell/application_manager/data_pipe_peek.cc View 8 chunks +6 lines, -8 lines 0 comments Download
M shell/application_manager/fetcher.h View 3 chunks +2 lines, -4 lines 0 comments Download
M shell/application_manager/fetcher.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/application_manager/identity.h View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/application_manager/identity.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M shell/application_manager/local_fetcher.h View 3 chunks +2 lines, -4 lines 0 comments Download
M shell/application_manager/local_fetcher.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M shell/application_manager/native_runner.h View 3 chunks +5 lines, -6 lines 0 comments Download
M shell/application_manager/network_fetcher.h View 5 chunks +9 lines, -9 lines 0 comments Download
M shell/application_manager/network_fetcher.cc View 5 chunks +15 lines, -14 lines 0 comments Download
M shell/application_manager/query_util.h View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/application_manager/query_util.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/application_manager/query_util_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/application_manager/shell_impl.h View 1 chunk +14 lines, -15 lines 0 comments Download
M shell/application_manager/shell_impl.cc View 3 chunks +16 lines, -15 lines 0 comments Download
M shell/application_manager/test.mojom View 1 chunk +1 line, -1 line 0 comments Download
M shell/child_controller.mojom View 1 chunk +1 line, -1 line 0 comments Download
M shell/child_main.cc View 13 chunks +31 lines, -31 lines 0 comments Download
M shell/child_process_host.h View 5 chunks +8 lines, -10 lines 0 comments Download
M shell/child_process_host.cc View 6 chunks +7 lines, -8 lines 0 comments Download
M shell/child_process_host_unittest.cc View 5 chunks +4 lines, -6 lines 0 comments Download
M shell/command_line_util.h View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/command_line_util.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/command_line_util_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/context.h View 2 chunks +1 line, -3 lines 0 comments Download
M shell/context.cc View 8 chunks +19 lines, -19 lines 0 comments Download
M shell/context_unittest.cc View 3 chunks +1 line, -3 lines 0 comments Download
M shell/data_pipe_peek_unittest.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M shell/desktop/main.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M shell/filename_util.h View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/filename_util.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/in_process_native_runner.h View 4 chunks +2 lines, -4 lines 0 comments Download
M shell/in_process_native_runner.cc View 3 chunks +1 line, -3 lines 0 comments Download
M shell/in_process_native_runner_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/init.h View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/init.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/native_application_support.h View 2 chunks +4 lines, -4 lines 0 comments Download
M shell/native_application_support.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M shell/native_runner_unittest.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M shell/out_of_process_native_runner.h View 3 chunks +1 line, -3 lines 0 comments Download
M shell/out_of_process_native_runner.cc View 3 chunks +1 line, -3 lines 0 comments Download
M shell/shell_apptest.cc View 6 chunks +52 lines, -55 lines 0 comments Download
M shell/shell_test_base.h View 3 chunks +5 lines, -6 lines 0 comments Download
M shell/shell_test_base.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M shell/shell_test_base_android.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/shell_test_base_unittest.cc View 10 chunks +12 lines, -14 lines 0 comments Download
M shell/shell_test_helper.h View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/shell_test_helper.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/task_runners.h View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/task_runners.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/test/pingable.mojom View 1 chunk +0 lines, -2 lines 0 comments Download
M shell/test/pingable_app.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M shell/url_resolver.h View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/url_resolver.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M shell/url_resolver_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
viettrungluu
5 years, 8 months ago (2015-04-09 02:29:36 UTC) #1
viettrungluu
Yuzhu, do you mind rubberstamping this? It's a purely mechanical change. (James and I have ...
5 years, 8 months ago (2015-04-09 17:40:21 UTC) #3
jamesr
lgtm https://codereview.chromium.org/1067173003/diff/1/shell/application_manager/application_manager_unittest.cc File shell/application_manager/application_manager_unittest.cc (right): https://codereview.chromium.org/1067173003/diff/1/shell/application_manager/application_manager_unittest.cc#newcode304 shell/application_manager/application_manager_unittest.cc:304: void B(const mojo::Callback<void()>& callback) override { this file ...
5 years, 8 months ago (2015-04-09 19:39:25 UTC) #5
viettrungluu
Thanks. On 2015/04/09 19:39:25, jamesr wrote: > lgtm > > https://codereview.chromium.org/1067173003/diff/1/shell/application_manager/application_manager_unittest.cc > File shell/application_manager/application_manager_unittest.cc (right): ...
5 years, 8 months ago (2015-04-09 19:41:38 UTC) #7
viettrungluu
Committed patchset #1 (id:1) manually as bd07e3aa605626017058a02c50ffbe267b81aef3 (presubmit successful).
5 years, 8 months ago (2015-04-09 19:43:34 UTC) #8
yzshen1
5 years, 8 months ago (2015-04-09 20:48:41 UTC) #9
Message was sent while issue was closed.
On 2015/04/09 19:43:34, viettrungluu wrote:
> Committed patchset #1 (id:1) manually as
> bd07e3aa605626017058a02c50ffbe267b81aef3 (presubmit successful).

Sorry, I missed this review request.
(it looks good to me)

Powered by Google App Engine
This is Rietveld 408576698