Move LaunchContainer enum to extension_constants.h.

Move LaunchContainer enum to extension_constants.h.

Move the Chrome-specific LaunchContainer enum out of
extensions/common/constants.h and into
chrome/common/extensions/extension_constants.h (it can't
live under chrome/browser/extensions since it's used by
AppLaunchInfo). For consistency, also move the LaunchType
enum to extension_constants.h.

Rename LaunchContainer's values from LAUNCH_* to
LAUNCH_CONTAINER_*, and also rename the LAUNCH_TYPE_* values
in AppContextMenu to USE_LAUNCH_TYPE_* to avoid confusion
with the LaunchType enum.

BUG=180083
TBR=sky@chromium.org,jar@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239202

[Daniel Erat, 2013-12-05 15:50:32]

yoz@ and benwells@: Mind looking at the extensions part of this?

xiyuan@: Adding you mostly as a heads-up for the renaming of some enum values in
AppContextMenu.

https://codereview.chromium.org/106713002/diff/1/chrome/common/extensions/ext...
File chrome/common/extensions/extension_constants.h (right):

https://codereview.chromium.org/106713002/diff/1/chrome/common/extensions/ext...
chrome/common/extensions/extension_constants.h:312: namespace extensions {
let me know if you'd prefer that these went in extension_misc like some of the
other enums in this file

[Yoyo Zhou, 2013-12-05 22:37:02]

LGTM

https://codereview.chromium.org/106713002/diff/1/chrome/browser/ui/app_list/a...
File chrome/browser/ui/app_list/app_context_menu.cc (right):

https://codereview.chromium.org/106713002/diff/1/chrome/browser/ui/app_list/a...
chrome/browser/ui/app_list/app_context_menu.cc:118: // Streamlined hosted apps
can only toggle between LAUNCH_TYPE_WINDOW and
nit: USE_LAUNCH_TYPE... (twice in this comment)

https://codereview.chromium.org/106713002/diff/1/chrome/common/extensions/ext...
File chrome/common/extensions/extension_constants.h (right):

https://codereview.chromium.org/106713002/diff/1/chrome/common/extensions/ext...
chrome/common/extensions/extension_constants.h:312: namespace extensions {
On 2013/12/05 15:50:33, Daniel Erat wrote:
> let me know if you'd prefer that these went in extension_misc like some of the
> other enums in this file

Nah, I think extension_misc is sort of against our namespace naming policy.

[benwells, 2013-12-05 23:22:04]

Bits I own not already covered lgtm

[Daniel Erat, 2013-12-06 03:14:12]

https://codereview.chromium.org/106713002/diff/1/chrome/browser/ui/app_list/a...
File chrome/browser/ui/app_list/app_context_menu.cc (right):

https://codereview.chromium.org/106713002/diff/1/chrome/browser/ui/app_list/a...
chrome/browser/ui/app_list/app_context_menu.cc:118: // Streamlined hosted apps
can only toggle between LAUNCH_TYPE_WINDOW and
On 2013/12/05 22:37:02, Yoyo Zhou wrote:
> nit: USE_LAUNCH_TYPE... (twice in this comment)

Done.

[commit-bot: I haz the power, 2013-12-06 04:17:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/106713002/40001

[commit-bot: I haz the power, 2013-12-06 05:52:38]

Retried try job too often on android_aosp for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...

[commit-bot: I haz the power, 2013-12-06 13:31:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/106713002/40001

[commit-bot: I haz the power, 2013-12-06 14:05:37]

Change committed as 239202