Move LaunchContainer enum to extension_constants.h.

chrome/common/extensions/extension_constants.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_CONSTANTS_H_
 #define CHROME_COMMON_EXTENSIONS_EXTENSION_CONSTANTS_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 291 matching lines @@
 
   // List of sizes for extension icons that can be defined in the manifest.
   extern const int kExtensionActionIconSizes[];
   extern const size_t kNumExtensionActionIconSizes;
 
   // List of sizes for extension icons that can be defined in the manifest.
   extern const int kScriptBadgeIconSizes[];
   extern const size_t kNumScriptBadgeIconSizes;
 }  // namespace extension_misc
 
+namespace extensions {

[Daniel Erat, 2013/12/05 15:50:33]

let me know if you'd prefer that these went in extension_misc like some of the
other enums in this file

[Yoyo Zhou, 2013/12/05 22:37:02]

Nah, I think extension_misc is sort of against our namespace naming policy.

+  // This enum is used for the launch type the user wants to use for an
+  // application.
+  // Do not remove items or re-order this enum as it is used in preferences
+  // and histograms.
+  enum LaunchType {
+    LAUNCH_TYPE_PINNED,
+    LAUNCH_TYPE_REGULAR,
+    LAUNCH_TYPE_FULLSCREEN,
+    LAUNCH_TYPE_WINDOW,
+
+    // Launch an app in the in the way a click on the NTP would,
+    // if no user pref were set.  Update this constant to change
+    // the default for the NTP and chrome.management.launchApp().
+    LAUNCH_TYPE_DEFAULT = LAUNCH_TYPE_REGULAR
+  };
+
+  // Don't remove items or change the order of this enum.  It's used in
+  // histograms and preferences.
+  enum LaunchContainer {
+    LAUNCH_CONTAINER_WINDOW,
+    LAUNCH_CONTAINER_PANEL,
+    LAUNCH_CONTAINER_TAB,
+    // For platform apps, which don't actually have a container (they just get a
+    // "onLaunched" event).
+    LAUNCH_CONTAINER_NONE
+  };
+}  // namespace extensions
+
 #endif  // CHROME_COMMON_EXTENSIONS_EXTENSION_CONSTANTS_H_