TextureUploadPerfTest.renaming should output renaming status

TextureUploadPerfTest.renaming should output renaming status

Currently this test outputs only the cpu/wall and gpu times.
We should also output the texture renaming status.

BUG=423481

[patro, 2015-04-07 12:15:38]

behara.ms@samsung.com changed reviewers:
+ dcastagna@chromium.org

[patro, 2015-04-07 12:15:38]

Kindly Review

Thanks,
Shyam Patro

[Daniele Castagna, 2015-04-07 16:27:08]

Hi!
Thank you for working on this, unfortunately I'm not sure this patch is doing
what you intended to do.
Please take a look at my comment for glGetIntegerv(GL_TEXTURE_BINDING_2D,
&current_tex_id) and correct me if I misunderstood anything.

https://codereview.chromium.org/1066863002/diff/1/gpu/perftests/texture_uploa...
File gpu/perftests/texture_upload_perftest.cc (right):

https://codereview.chromium.org/1066863002/diff/1/gpu/perftests/texture_uploa...
gpu/perftests/texture_upload_perftest.cc:520:
glGetIntegerv(GL_TEXTURE_BINDING_2D, &current_tex_id);
This returns the name of the texture currently bound, that is the name of the
texture we just bound with glBindTexture(GL_TEXTURE_2D, texture_id).
This should always return texture_id.

AFAIU renaming is something the driver does under the hood and you should not be
able to see different texture names that were never generated. If this is
happening anywhere, this is a bug, let's investigate it.

[patro, 2015-04-08 15:19:49]

https://codereview.chromium.org/1066863002/diff/1/gpu/perftests/texture_uploa...
File gpu/perftests/texture_upload_perftest.cc (right):

https://codereview.chromium.org/1066863002/diff/1/gpu/perftests/texture_uploa...
gpu/perftests/texture_upload_perftest.cc:520:
glGetIntegerv(GL_TEXTURE_BINDING_2D, &current_tex_id);
You are right this patch doesn't work as intended.
Then the only way to check if the gpu renames the texture is 
gpu_time > cpu_time

For this test we are printing only the cpu_time/gpu_time/wall_time
It will be more informative if we can also print if the gpu is renaming
textures.

On 2015/04/07 16:27:08, Daniele Castagna wrote:
> This returns the name of the texture currently bound, that is the name of the
> texture we just bound with glBindTexture(GL_TEXTURE_2D, texture_id).
> This should always return texture_id.
> 
> AFAIU renaming is something the driver does under the hood and you should not
be
> able to see different texture names that were never generated. If this is
> happening anywhere, this is a bug, let's investigate it.
>

[Daniele Castagna, 2015-04-14 16:13:15]

https://codereview.chromium.org/1066863002/diff/1/gpu/perftests/texture_uploa...
File gpu/perftests/texture_upload_perftest.cc (right):

https://codereview.chromium.org/1066863002/diff/1/gpu/perftests/texture_uploa...
gpu/perftests/texture_upload_perftest.cc:520:
glGetIntegerv(GL_TEXTURE_BINDING_2D, &current_tex_id);
On 2015/04/08 at 15:19:49, patro wrote:
> You are right this patch doesn't work as intended.
> Then the only way to check if the gpu renames the texture is 
> gpu_time > cpu_time
> 
> For this test we are printing only the cpu_time/gpu_time/wall_time
> It will be more informative if we can also print if the gpu is renaming
textures.
> 
> On 2015/04/07 16:27:08, Daniele Castagna wrote:
> > This returns the name of the texture currently bound, that is the name of
the
> > texture we just bound with glBindTexture(GL_TEXTURE_2D, texture_id).
> > This should always return texture_id.
> > 
> > AFAIU renaming is something the driver does under the hood and you should
not be
> > able to see different texture names that were never generated. If this is
> > happening anywhere, this is a bug, let's investigate it.
> >

I was thinking about this perftest to print out raw data, then another script
could interpret the data and print out more human readable results.
In this way the final results could be determined given the raw data of all the
results (on different platforms/drivers) and not a single data point.

[sivag, 2015-04-27 12:39:01]

siva.gunturi@samsung.com changed reviewers:
+ siva.gunturi@samsung.com

[sivag, 2015-04-27 12:39:02]

https://codereview.chromium.org/1066863002/diff/1/gpu/perftests/texture_uploa...
File gpu/perftests/texture_upload_perftest.cc (right):

https://codereview.chromium.org/1066863002/diff/1/gpu/perftests/texture_uploa...
gpu/perftests/texture_upload_perftest.cc:520:
glGetIntegerv(GL_TEXTURE_BINDING_2D, &current_tex_id);
On 2015/04/14 16:13:15, Daniele Castagna wrote:
> On 2015/04/08 at 15:19:49, patro wrote:
> > You are right this patch doesn't work as intended.
> > Then the only way to check if the gpu renames the texture is 
> > gpu_time > cpu_time
> > 
> > For this test we are printing only the cpu_time/gpu_time/wall_time
> > It will be more informative if we can also print if the gpu is renaming
> textures.
> > 
> > On 2015/04/07 16:27:08, Daniele Castagna wrote:
> > > This returns the name of the texture currently bound, that is the name of
> the
> > > texture we just bound with glBindTexture(GL_TEXTURE_2D, texture_id).
> > > This should always return texture_id.
> > > 
> > > AFAIU renaming is something the driver does under the hood and you should
> not be
> > > able to see different texture names that were never generated. If this is
> > > happening anywhere, this is a bug, let's investigate it.
> > >
> 
> I was thinking about this perftest to print out raw data, then another script
> could interpret the data and print out more human readable results.
> In this way the final results could be determined given the raw data of all
the
> results (on different platforms/drivers) and not a single data point.

Daniele,
Can you elaborate more on this?
How this differs from comparing a two data arrays, 
1. the uploaded data pattern 2. the one read using glreadpixels
Which we are doing using EXPECT_EQ(pixels[i], pixels_rendered);?

[sivag, 2016-06-01 16:54:13]

Description was changed from

==========
TextureUploadPerfTest.renaming should output renaming status

Currently this test outputs only the cpu/wall and gpu times.
We should also output the texture renaming status.

BUG=423481
==========

to

==========
TextureUploadPerfTest.renaming should output renaming status

Currently this test outputs only the cpu/wall and gpu times.
We should also output the texture renaming status.

BUG=423481
==========

[sivag, 2016-06-01 16:54:13]

siva.gunturi@samsung.com changed reviewers:
- siva.gunturi@samsung.com