Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1066843003: MIPS: JSEntryTrampoline: check for stack space before pushing arguments (Closed)

Created:
5 years, 8 months ago by balazs.kilvady
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: JSEntryTrampoline: check for stack space before pushing arguments Port 146598f44a1efd0f942745abfd6c08a073972c01 Original commit message: Optimistically pushing a lot of arguments can run into the stack limit of the process, at least on operating systems where this limit is close to the limit that V8 sets for itself. BUG=chromium:469768 LOG=y Committed: https://crrev.com/b635967b90615f370e0628039a7b55775ad0ed59 Cr-Commit-Position: refs/heads/master@{#27634}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add missing SmiTag() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -51 lines) Patch
M src/mips/builtins-mips.cc View 1 5 chunks +47 lines, -26 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 5 chunks +46 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
balazs.kilvady
5 years, 8 months ago (2015-04-07 13:22:43 UTC) #2
Jakob Kummerow
https://codereview.chromium.org/1066843003/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/1066843003/diff/1/src/mips/builtins-mips.cc#newcode876 src/mips/builtins-mips.cc:876: __ Push(a1, argc); Note that argc needs to be ...
5 years, 8 months ago (2015-04-07 13:23:51 UTC) #3
balazs.kilvady
https://codereview.chromium.org/1066843003/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/1066843003/diff/1/src/mips/builtins-mips.cc#newcode876 src/mips/builtins-mips.cc:876: __ Push(a1, argc); On 2015/04/07 13:23:51, Jakob wrote: > ...
5 years, 8 months ago (2015-04-07 13:49:53 UTC) #4
dusmil.imgtec
lgtm.
5 years, 8 months ago (2015-04-07 14:58:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066843003/20001
5 years, 8 months ago (2015-04-07 15:38:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 15:59:07 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 15:59:25 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b635967b90615f370e0628039a7b55775ad0ed59
Cr-Commit-Position: refs/heads/master@{#27634}

Powered by Google App Engine
This is Rietveld 408576698