Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1061263003: Fix missing SmiTag in failure path of r27614 (Closed)

Created:
5 years, 8 months ago by Jakob Kummerow
Modified:
5 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix missing SmiTag in failure path of r27614 BUG=chromium:469768 LOG=n Committed: https://crrev.com/46f761e1f2f6b8134812dd3b283464b29130482a Cr-Commit-Position: refs/heads/master@{#27627}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
PTAL.
5 years, 8 months ago (2015-04-07 12:22:51 UTC) #2
Yang
On 2015/04/07 12:22:51, Jakob wrote: > PTAL. lgtm.
5 years, 8 months ago (2015-04-07 12:26:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1061263003/1
5 years, 8 months ago (2015-04-07 12:27:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 12:47:43 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 12:47:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46f761e1f2f6b8134812dd3b283464b29130482a
Cr-Commit-Position: refs/heads/master@{#27627}

Powered by Google App Engine
This is Rietveld 408576698