content/test/test_render_frame_host.cc - Issue 1066823004: PlzNavigate: improve tracking of improper subframe swap-out.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/test_render_frame_host.cc

Issue 1066823004: PlzNavigate: improve tracking of improper subframe swap-out. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed NI::GetNavigationRequestForNodeForTesting signature. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/test/test_render_frame_host.cc

diff --git a/content/test/test_render_frame_host.cc b/content/test/test_render_frame_host.cc

index 93bc602599602e5a8ce517628c914dc2b1c966c9..4ec5f92557c76987b174c6536e8d0407d7d486ba 100644

--- a/content/test/test_render_frame_host.cc

+++ b/content/test/test_render_frame_host.cc

@@ -236,7 +236,8 @@ void TestRenderFrameHost::PrepareForCommitWithServerRedirect(

// PlzNavigate

NavigationRequest* request =

static_cast<NavigatorImpl*>(frame_tree_node_->navigator())

- ->GetNavigationRequestForNodeForTesting(frame_tree_node_);

+ ->GetNavigationRequestForNodeForTesting(

+ frame_tree_node_->frame_tree_node_id());

CHECK(request);

// Simulate a beforeUnload ACK from the renderer if the browser is waiting for

« content/browser/frame_host/render_frame_host_manager.cc ('K') | « content/browser/frame_host/render_frame_host_manager.cc ('k') | no next file » | no next file with comments »