content/browser/frame_host/render_frame_host_manager.cc - Issue 1066823004: PlzNavigate: improve tracking of improper subframe swap-out.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 1066823004: PlzNavigate: improve tracking of improper subframe swap-out. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed NI::GetNavigationRequestForNodeForTesting signature. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigator_impl_unittest.cc ('K') | « content/browser/frame_host/navigator_impl_unittest.cc ('k') | content/test/test_render_frame_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager.cc

diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc

index f19fe90633e703704c7cdc1bc39a2844a4fc747f..931c73c3b4c4db798cbd86a512c3b1f420a0a5c6 100644

--- a/content/browser/frame_host/render_frame_host_manager.cc

+++ b/content/browser/frame_host/render_frame_host_manager.cc

@@ -665,6 +665,7 @@ void RenderFrameHostManager::DiscardUnusedFrame(

RenderFrameProxyHost* proxy =

new RenderFrameProxyHost(site_instance, frame_tree_node_);

+ CHECK(!GetRenderFrameProxyHost(site_instance));

clamy 2015/04/14 15:32:04 Maybe move the CHECK above the creation of the new

carlosk 2015/04/23 16:10:13 Done.

proxy_hosts_[site_instance->GetId()] = proxy;

// Check if the RenderFrameHost is already swapped out, to avoid swapping it