Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: content/browser/frame_host/navigator_impl.h

Issue 1066823004: PlzNavigate: improve tracking of improper subframe swap-out. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed NI::GetNavigationRequestForNodeForTesting signature. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.h
diff --git a/content/browser/frame_host/navigator_impl.h b/content/browser/frame_host/navigator_impl.h
index debf309aba67d4d3918bab66bedd250f7993ac0a..de21c96e3e639cee3ec40bf533e22cb1e4bd1d1c 100644
--- a/content/browser/frame_host/navigator_impl.h
+++ b/content/browser/frame_host/navigator_impl.h
@@ -88,7 +88,7 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
// PlzNavigate
// Returns the navigation request for a given node. Used in tests.
NavigationRequest* GetNavigationRequestForNodeForTesting(
nasko 2015/04/14 16:06:29 nit: I'd drop the "ForNode" part of the name, as i
carlosk 2015/04/23 16:10:12 This method doesn't exist anymore.
- FrameTreeNode* frame_tree_node);
+ int64 frame_tree_node_id);
private:
// Holds data used to track browser side navigation metrics.

Powered by Google App Engine
This is Rietveld 408576698