content/browser/frame_host/navigator_impl.cc - Issue 1066823004: PlzNavigate: improve tracking of improper subframe swap-out.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 1066823004: PlzNavigate: improve tracking of improper subframe swap-out. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed NI::GetNavigationRequestForNodeForTesting signature. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigator_impl.h ('K') | « content/browser/frame_host/navigator_impl.h ('k') | content/browser/frame_host/navigator_impl_unittest.cc » ('j') | content/browser/frame_host/navigator_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index 527eda7d6c833688a45331a6b1d1c5ee40d9771b..0f10586e77db658792655107487414627a312f4a 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -736,8 +736,8 @@ void NavigatorImpl::CancelNavigation(FrameTreeNode* frame_tree_node) {

// PlzNavigate

NavigationRequest* NavigatorImpl::GetNavigationRequestForNodeForTesting(

- FrameTreeNode* frame_tree_node) {

- return navigation_request_map_.get(frame_tree_node->frame_tree_node_id());

+ int64 frame_tree_node_id) {

+ return navigation_request_map_.get(frame_tree_node_id);

}

bool NavigatorImpl::IsWaitingForBeforeUnloadACK(