Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1066763002: Don't use select() in interactive python shell (Closed)

Created:
5 years, 8 months ago by Sam Clegg
Modified:
5 years, 8 months ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Project:
naclports
Visibility:
Public.

Description

Don't use select() in interactive python shell This fixes the python interactive shell when running under sel_ldr (in this case select() will always return ENOSYS which python doesn't handle and we end up an infinite loop). This wasn't a problem in the past since we didn't include nacl_io on the link line, and hence python didn't compile with select() support. R=bradnelson@google.com Committed: https://chromium.googlesource.com/external/naclports/+/4112c104e6737542b6c04430490d103495c3a7a8

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -5 lines) Patch
M ports/python/nacl.patch View 2 chunks +18 lines, -1 line 0 comments Download
M ports/python3/nacl.patch View 1 2 chunks +35 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Sam Clegg
Found this while looking into a build for rabbithole.
5 years, 8 months ago (2015-04-07 00:17:43 UTC) #2
bradn
lgtm
5 years, 8 months ago (2015-04-07 00:58:20 UTC) #4
Sam Clegg
5 years, 8 months ago (2015-04-07 01:06:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4112c104e6737542b6c04430490d103495c3a7a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698