Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: sync/protocol/app_specifics.proto

Issue 1066623008: Sync bookmark app icon urls and sizes, and download icons for new apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix failing tests and extra checks Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/protocol/app_specifics.proto
diff --git a/sync/protocol/app_specifics.proto b/sync/protocol/app_specifics.proto
index a43ea2fd01f9cd9b61956340e6b88ff4d95feaf3..f1921279c4954b5260023e25e289f4183bdd744b 100644
--- a/sync/protocol/app_specifics.proto
+++ b/sync/protocol/app_specifics.proto
@@ -38,6 +38,15 @@ message AppNotificationSettings {
optional string oauth_client_id = 3;
}
+// Information about a linked app icon.
+message LinkedAppIconInfo {
+ // The URL of the app icon.
+ optional string url = 1;
+
+ // The size of the app icon.
calamity 2015/04/24 05:05:40 // The size of the app icon in DIPs.
benwells 2015/04/27 09:54:54 Done.
+ optional uint32 size = 2;
+}
+
// Properties of app sync objects.
//
// For now, an app is just an extension. We keep the two data types
@@ -79,4 +88,8 @@ message AppSpecifics {
// This is the color to use when generating bookmark app icons. The string is
// in #rrggbb or #rgb syntax, e.g. #d8d8d8.
optional string bookmark_app_icon_color = 8;
+
+ // This is information about linked icons (that is, icons that are downloaded
+ // from outside the app's bundle of files.
+ repeated LinkedAppIconInfo linked_app_icons = 9;
}

Powered by Google App Engine
This is Rietveld 408576698