Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2979)

Unified Diff: chrome/common/extensions/manifest_handlers/linked_app_icons.cc

Issue 1066623008: Sync bookmark app icon urls and sizes, and download icons for new apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix failing tests and extra checks Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_handlers/linked_app_icons.cc
diff --git a/chrome/common/extensions/manifest_handlers/linked_app_icons.cc b/chrome/common/extensions/manifest_handlers/linked_app_icons.cc
new file mode 100644
index 0000000000000000000000000000000000000000..bf2a1238983f3584bc4bcf91fee201d9c946c2fb
--- /dev/null
+++ b/chrome/common/extensions/manifest_handlers/linked_app_icons.cc
@@ -0,0 +1,108 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
benwells 2015/04/23 06:39:00 Self nit: 2015
benwells 2015/04/27 09:54:54 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/extensions/manifest_handlers/linked_app_icons.h"
+
+#include "base/lazy_instance.h"
+#include "base/strings/utf_string_conversions.h"
+#include "base/values.h"
+#include "extensions/common/manifest.h"
+#include "extensions/common/manifest_constants.h"
+
+namespace extensions {
+
+namespace keys = manifest_keys;
+namespace errors = manifest_errors;
+
+namespace {
+
+static base::LazyInstance<LinkedAppIcons> g_empty_linked_app_icons =
+ LAZY_INSTANCE_INITIALIZER;
+
+const LinkedAppIcons& GetInfo(const Extension* extension) {
+ LinkedAppIcons* info = static_cast<LinkedAppIcons*>(
+ extension->GetManifestData(keys::kLinkedAppIcons));
+ return info ? *info : g_empty_linked_app_icons.Get();
+}
+
+} // namespace
+
+LinkedAppIcons::IconInfo::IconInfo() {
+}
+
+LinkedAppIcons::IconInfo::~IconInfo() {
+}
+
+LinkedAppIcons::LinkedAppIcons() {
+}
+
+LinkedAppIcons::~LinkedAppIcons() {
+}
+
+// static
+const LinkedAppIcons& LinkedAppIcons::GetLinkedAppIcons(
+ const Extension* extension) {
+ return GetInfo(extension);
+}
+
+LinkedAppIconsHandler::LinkedAppIconsHandler() {
+}
+
+LinkedAppIconsHandler::~LinkedAppIconsHandler() {
+}
+
+bool LinkedAppIconsHandler::Parse(Extension* extension, base::string16* error) {
+ scoped_ptr<LinkedAppIcons> linked_app_icons(new LinkedAppIcons);
+
+ const base::Value* icons_value = nullptr;
+ const base::ListValue* icons_list = nullptr;
+ if (extension->manifest()->Get(keys::kLinkedAppIcons, &icons_value)) {
+ if (!icons_value->GetAsList(&icons_list)) {
+ *error = base::UTF8ToUTF16(
+ extensions::manifest_errors::kInvalidLinkedAppIcons);
+ return false;
+ }
+
+ for (const base::Value* icon_value : *icons_list) {
+ const base::DictionaryValue* icon_dict = nullptr;
+ if (!icon_value->GetAsDictionary(&icon_dict)) {
+ *error = base::UTF8ToUTF16(
+ extensions::manifest_errors::kInvalidLinkedAppIcon);
+ return false;
+ }
+
+ std::string url_string;
+ if (!icon_dict->GetString(keys::kLinkedAppIconURL, &url_string)) {
+ *error = base::UTF8ToUTF16(
+ extensions::manifest_errors::kInvalidLinkedAppIconURL);
+ return false;
+ }
+
+ LinkedAppIcons::IconInfo info;
+ info.url = GURL(url_string);
+ if (!info.url.is_valid()) {
+ *error = base::UTF8ToUTF16(
+ extensions::manifest_errors::kInvalidLinkedAppIconURL);
+ return false;
+ }
+
+ if (!icon_dict->GetInteger(keys::kLinkedAppIconSize, &info.size)) {
+ *error = base::UTF8ToUTF16(
+ extensions::manifest_errors::kInvalidLinkedAppIconSize);
+ return false;
+ }
+
+ linked_app_icons->icons.push_back(info);
+ }
+ }
+
+ extension->SetManifestData(keys::kLinkedAppIcons, linked_app_icons.release());
+ return true;
+}
+
+const std::vector<std::string> LinkedAppIconsHandler::Keys() const {
+ return SingleKey(keys::kLinkedAppIcons);
+}
+
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698