extensions/common/manifest_constants.h - Issue 1066623008: Sync bookmark app icon urls and sizes, and download icons for new apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_constants.h

Issue 1066623008: Sync bookmark app icon urls and sizes, and download icons for new apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing tests and extra checks Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/manifest_handlers/linked_app_icons.cc ('K') | « chrome/common/extensions/manifest_handlers/linked_app_icons.cc ('k') | extensions/common/manifest_constants.cc » ('j') | sync/protocol/app_specifics.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/manifest_constants.h

diff --git a/extensions/common/manifest_constants.h b/extensions/common/manifest_constants.h

index a6a9c6d9270b9a361bf14420d9bbecbf28583fd7..fa587015a3808cfc6a40800e3447c8cd334e6986 100644

--- a/extensions/common/manifest_constants.h

+++ b/extensions/common/manifest_constants.h

@@ -82,6 +82,9 @@ extern const char kLaunchLocalPath[];

extern const char kLaunchWebURL[];

extern const char kLaunchWidth[];

extern const char kLayouts[];

+extern const char kLinkedAppIcons[];

+extern const char kLinkedAppIconURL[];

+extern const char kLinkedAppIconSize[];

extern const char kManifestVersion[];

extern const char kMatchAboutBlank[];

extern const char kMatches[];

@@ -352,6 +355,10 @@ extern const char kInvalidLauncherPagePage[];

extern const char kInvalidLaunchContainer[];

extern const char kInvalidLaunchValue[];

extern const char kInvalidLaunchValueContainer[];

+extern const char kInvalidLinkedAppIcon[];

+extern const char kInvalidLinkedAppIconSize[];

+extern const char kInvalidLinkedAppIconURL[];

+extern const char kInvalidLinkedAppIcons[];

extern const char kInvalidManifest[];

extern const char kInvalidManifestVersion[];

extern const char kInvalidManifestVersionOld[];