DevTools: migrate from ui-setting to settings extension point.

DevTools: migrate from ui-setting to settings extension point.
This is the first patch in making settings modular.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193266

[pfeldman, 2015-04-06 13:49:32]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2015-04-06 14:40:37]

https://codereview.chromium.org/1066573002/diff/1/Source/devtools/front_end/m...
File Source/devtools/front_end/main/module.json (right):

https://codereview.chromium.org/1066573002/diff/1/Source/devtools/front_end/m...
Source/devtools/front_end/main/module.json:234: "title-mac": "Enable Cmd + 1-9
shortcut to switch panels",
What about the following?
"title": [ { "platform": "mac", "value": "...." }, {...}]
This would match shortcuts. We can support both string and array.

https://codereview.chromium.org/1066573002/diff/1/Source/devtools/front_end/s...
File Source/devtools/front_end/settings/SettingsScreen.js (right):

https://codereview.chromium.org/1066573002/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/settings/SettingsScreen.js:249: var setting =
WebInspector.settings[settingName];
Why not |WI.settings.createSetting(settingName)|?

https://codereview.chromium.org/1066573002/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/settings/SettingsScreen.js:253: var parentFieldset =
descriptor["parentSettingName"] ?
this._nameToSettingFieldset.get(descriptor["parentSettingName"]) : null;
This depends on the order of processing.

https://codereview.chromium.org/1066573002/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/settings/SettingsScreen.js:278:
settingControl.appendChild(fieldSet);
Why don't you create fieldset when you need it because of "parentSettingName" ?

[pfeldman, 2015-04-06 17:15:00]

https://codereview.chromium.org/1066573002/diff/1/Source/devtools/front_end/m...
File Source/devtools/front_end/main/module.json (right):

https://codereview.chromium.org/1066573002/diff/1/Source/devtools/front_end/m...
Source/devtools/front_end/main/module.json:234: "title-mac": "Enable Cmd + 1-9
shortcut to switch panels",
On 2015/04/06 14:40:36, dgozman wrote:
> What about the following?
> "title": [ { "platform": "mac", "value": "...." }, {...}]
> This would match shortcuts. We can support both string and array.

Acknowledged.

https://codereview.chromium.org/1066573002/diff/1/Source/devtools/front_end/s...
File Source/devtools/front_end/settings/SettingsScreen.js (right):

https://codereview.chromium.org/1066573002/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/settings/SettingsScreen.js:249: var setting =
WebInspector.settings[settingName];
On 2015/04/06 14:40:36, dgozman wrote:
> Why not |WI.settings.createSetting(settingName)|?

Because I don't know the default value yet.

https://codereview.chromium.org/1066573002/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/settings/SettingsScreen.js:253: var parentFieldset =
descriptor["parentSettingName"] ?
this._nameToSettingFieldset.get(descriptor["parentSettingName"]) : null;
On 2015/04/06 14:40:36, dgozman wrote:
> This depends on the order of processing.

Yes and I kinda think that this is alright.

https://codereview.chromium.org/1066573002/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/settings/SettingsScreen.js:278:
settingControl.appendChild(fieldSet);
On 2015/04/06 14:40:36, dgozman wrote:
> Why don't you create fieldset when you need it because of "parentSettingName"
?

Ok, sure.

[dgozman, 2015-04-07 10:49:35]

lgtm

[pfeldman, 2015-04-07 11:24:32]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2015-04-07 11:24:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1066573002/20001

[commit-bot: I haz the power, 2015-04-07 13:03:46]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193266