Source/devtools/front_end/settings/module.json - Issue 1066573002: DevTools: migrate from ui-setting to settings extension point.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/devtools/front_end/settings/module.json

Issue 1066573002: DevTools: migrate from ui-setting to settings extension point. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments addressed Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 {	1 {

2 "extensions": [	2 "extensions": [

3 {	3 {

4 "type": "@WebInspector.ActionDelegate",	4 "type": "@WebInspector.ActionDelegate",

5 "actionId": "settings.show",	5 "actionId": "settings.show",

6 "className": "WebInspector.SettingsController.SettingsScreenActionDe legate",	6 "className": "WebInspector.SettingsController.SettingsScreenActionDe legate",

7 "bindings": [	7 "bindings": [

8 {	8 {

9 "shortcut": "F1 Shift+?"	9 "shortcut": "F1 Shift+?"

10 }	10 }

11 ]	11 ]

12 },	12 },

13 {	13 {

14 "type": "@WebInspector.StatusBarItem.Provider",	14 "type": "@WebInspector.StatusBarItem.Provider",

15 "actionId": "settings.show",	15 "actionId": "settings.show",

16 "location": "toolbar-right",	16 "location": "toolbar-right",

17 "title": "Settings",	17 "title": "Settings",

18 "order": 3,	18 "order": 3,

19 "elementClass": "settings-status-bar-item"	19 "elementClass": "settings-status-bar-item"

20 },	20 },

21 {	21 {

22 "type": "ui-setting",	22 "type": "@WebInspector.SettingUI",

23 "section": "Sources",	23 "category": "Sources",

24 "settingType": "custom",	24 "className": "WebInspector.SettingsScreen.SkipStackFramePatternSetti ngUI"

25 "className": "WebInspector.SettingsScreen.SkipStackFramePatternSetti ngDelegate"

26 }	25 }

27 ],	26 ],

28 "dependencies": [	27 "dependencies": [

29 "components",	28 "components",

30 "toolbox"	29 "toolbox"

31 ],	30 ],

32 "scripts": [	31 "scripts": [

33 "EditFileSystemDialog.js",	32 "EditFileSystemDialog.js",

34 "FrameworkBlackboxDialog.js",	33 "FrameworkBlackboxDialog.js",

35 "SettingsScreen.js"	34 "SettingsScreen.js"

36 ]	35 ]

37 }	36 }

OLD	NEW

« no previous file with comments | « Source/devtools/front_end/settings/SettingsScreen.js ('k') | Source/devtools/front_end/source_frame/module.json » ('j') | no next file with comments »