Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 1066373002: X87: Reimplement Maps and Sets in JS (Closed)

Created:
4 years, 4 months ago by chunyang.dai
Modified:
4 years, 4 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Reimplement Maps and Sets in JS port 909500aa1db9789b68e101045a6359a7fcb30e83 (r27605) original commit message: Previously, the only optimized code path for Maps and Sets was for String keys. This was achieved through an implementation of various complex operations in Hydrogen. This approach was neither scalable nor forward-compatible. This patch adds the necessary intrinsics to implement Maps and Sets almost entirely in JS. The added intrinsics are: %_FixedArrayGet %_FixedArraySet %_TheHole %_JSCollectionGetTable %_StringGetRawHashField With these additions, as well as a few changes to what's exposed as runtime functions, most of the C++ code backing Maps and Sets is gone (including both runtime code in objects.cc and Crankshaft in hydrogen.cc). BUG= Committed: https://crrev.com/56600a35a49ffa5abcba66b14839089de3589ad9 Cr-Commit-Position: refs/heads/master@{#27681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
chunyang.dai
PTAL.
4 years, 4 months ago (2015-04-09 01:29:50 UTC) #2
Weiliang
lgtm
4 years, 4 months ago (2015-04-09 01:42:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066373002/1
4 years, 4 months ago (2015-04-09 01:42:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2015-04-09 02:24:11 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/56600a35a49ffa5abcba66b14839089de3589ad9 Cr-Commit-Position: refs/heads/master@{#27681}
4 years, 4 months ago (2015-04-09 02:24:29 UTC) #7
Michael Hablich
4 years, 4 months ago (2015-04-09 06:49:11 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1073723002/ by hablich@chromium.org.

The reason for reverting is: Reverting as it resulted in a closed waterfall..

Powered by Google App Engine
This is Rietveld 408576698