Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1396)

Issue 1066183002: content/aura: Use a PaintRecorder to access the Canvas for painting. (Closed)

Created:
5 years, 8 months ago by danakj
Modified:
5 years, 8 months ago
Reviewers:
sadrul, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, enne (OOO), oshima, piman, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content/aura: Use a PaintRecorder to access the Canvas for painting. Don't use the canvas() from the PaintContext so that we can have the PaintContext be backed by a DisplayItemList instead in the future. Access to the Canvas should be done through a PaintRecorder. R=piman@chromium.org, sadrul BUG=466426 Committed: https://crrev.com/79b6513237fc18e4b67c2a686dacfa1ee89873a3 Cr-Commit-Position: refs/heads/master@{#324153}

Patch Set 1 #

Total comments: 2

Patch Set 2 : content-recorder: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M content/browser/web_contents/aura/gesture_nav_simple.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/web_contents/aura/shadow_layer_delegate.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
danakj
5 years, 8 months ago (2015-04-07 21:08:12 UTC) #1
piman
lgtm
5 years, 8 months ago (2015-04-07 21:11:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066183002/1
5 years, 8 months ago (2015-04-07 21:11:55 UTC) #4
sadrul
lgtm https://codereview.chromium.org/1066183002/diff/1/content/browser/web_contents/aura/shadow_layer_delegate.cc File content/browser/web_contents/aura/shadow_layer_delegate.cc (right): https://codereview.chromium.org/1066183002/diff/1/content/browser/web_contents/aura/shadow_layer_delegate.cc#newcode54 content/browser/web_contents/aura/shadow_layer_delegate.cc:54: paint); I wonder if there's a reason this ...
5 years, 8 months ago (2015-04-07 21:12:15 UTC) #5
danakj
https://codereview.chromium.org/1066183002/diff/1/content/browser/web_contents/aura/shadow_layer_delegate.cc File content/browser/web_contents/aura/shadow_layer_delegate.cc (right): https://codereview.chromium.org/1066183002/diff/1/content/browser/web_contents/aura/shadow_layer_delegate.cc#newcode54 content/browser/web_contents/aura/shadow_layer_delegate.cc:54: paint); On 2015/04/07 21:12:15, sadrul wrote: > I wonder ...
5 years, 8 months ago (2015-04-07 21:13:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066183002/20001
5 years, 8 months ago (2015-04-07 21:20:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 23:21:40 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 23:22:40 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/79b6513237fc18e4b67c2a686dacfa1ee89873a3
Cr-Commit-Position: refs/heads/master@{#324153}

Powered by Google App Engine
This is Rietveld 408576698