Array and map members for unions.

Array and map members for unions.

BUG=
R=yzshen@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/0d829c56ca6dbd59ffcf2cfcf900bbeb86e97142

[azani, 2015-04-20 21:02:29]

azani@chromium.org changed reviewers:
+ yzshen@chromium.org

[azani, 2015-04-20 21:02:29]

please take a look

[yzshen1, 2015-04-21 07:25:23]

https://codereview.chromium.org/1065653006/diff/20001/mojo/public/tools/bindi...
File mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl
(right):

https://codereview.chromium.org/1065653006/diff/20001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl:65:
reinterpret_cast<{{field.kind|cpp_field_type}}*>(&data),
is it better to use &data.f_{{field.name}} instead of &data?

https://codereview.chromium.org/1065653006/diff/20001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl:68:
mojo::internal::EncodeHandle(&data.f_{{field.name}}, handles);
wrong indent.

https://codereview.chromium.org/1065653006/diff/20001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl:83:
reinterpret_cast<{{field.kind|cpp_field_type}}*>(&data),
is it better to use &data.f_{{field.name}} instead of &data?

[yzshen1, 2015-04-21 16:39:14]

https://codereview.chromium.org/1065653006/diff/20001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/tests/union_unittest.cc (right):

https://codereview.chromium.org/1065653006/diff/20001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/union_unittest.cc:743: void* raw_buf =
buf.Leak();
Please dispose it properly.

https://codereview.chromium.org/1065653006/diff/20001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/union_unittest.cc:810: void* raw_buf =
buf.Leak();
ditto.

[azani, 2015-04-21 17:43:33]

ptal

https://codereview.chromium.org/1065653006/diff/20001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/tests/union_unittest.cc (right):

https://codereview.chromium.org/1065653006/diff/20001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/union_unittest.cc:743: void* raw_buf =
buf.Leak();
On 2015/04/21 16:39:14, yzshen1 wrote:
> Please dispose it properly.

Done.

https://codereview.chromium.org/1065653006/diff/20001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/union_unittest.cc:810: void* raw_buf =
buf.Leak();
On 2015/04/21 16:39:14, yzshen1 wrote:
> ditto.

Done.

https://codereview.chromium.org/1065653006/diff/20001/mojo/public/tools/bindi...
File mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl
(right):

https://codereview.chromium.org/1065653006/diff/20001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl:65:
reinterpret_cast<{{field.kind|cpp_field_type}}*>(&data),
On 2015/04/21 07:25:22, yzshen1 wrote:
> is it better to use &data.f_{{field.name}} instead of &data?

Maybe it's a bit more readable if we include the field name.

https://codereview.chromium.org/1065653006/diff/20001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl:68:
mojo::internal::EncodeHandle(&data.f_{{field.name}}, handles);
On 2015/04/21 07:25:23, yzshen1 wrote:
> wrong indent.

Done.

https://codereview.chromium.org/1065653006/diff/20001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl:83:
reinterpret_cast<{{field.kind|cpp_field_type}}*>(&data),
On 2015/04/21 07:25:22, yzshen1 wrote:
> is it better to use &data.f_{{field.name}} instead of &data?

Done.

[yzshen1, 2015-04-21 17:52:33]

lgtm

[azani, 2015-04-21 18:31:33]

Committed patchset #4 (id:60001) manually as
0d829c56ca6dbd59ffcf2cfcf900bbeb86e97142 (presubmit successful).