mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl - Issue 1065653006: Array and map members for unions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl

Issue 1065653006: Array and map members for unions. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/interfaces/bindings/tests/test_unions.mojom ('k') | mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl

index f29ea2dd589b91b7d440f872ea9bdb144ee270d8..f84f60a73015a2f1e7954cccdc986bd5de32c268 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl

@@ -32,7 +32,7 @@ class {{class_name}} {

// a struct." - Section 9.5.2 ISO/IEC 14882:2011 (The C++ Spec)

union MOJO_ALIGNAS(8) Union_ {

{%- for field in union.fields %}

-{%- if field.kind|is_string_kind or field.kind|is_struct_kind %}

+{%- if field.kind|is_object_kind %}

uint64_t f_{{field.name}};

{%- elif field.kind.spec == 'b' %}

uint8_t f_{{field.name}} : 1;