Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 1065413002: <webview>: Don't reset allowtransparency and allowscaling between createGuest and attachGuest (Closed)

Created:
5 years, 8 months ago by Fady Samuel
Modified:
5 years, 8 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

<webview>: Don't reset allowtransparency and allowscaling between createGuest and attachGuest https://codereview.chromium.org/1033373003/ introduced lazily issuing updated GuestView attributes between create and attach. The AllowTransparency and AllowScaling attributes were defaulting to false if not available in the attach params and so they were getting reset on attach. This CL fixes the issue by only updating the attributes if they are passed along on attach. BUG=471997 Committed: https://crrev.com/3f5bfc1e91367878b8d632f62ae482f4205a15a3 Cr-Commit-Position: refs/heads/master@{#324327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -18 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/simple/main.js View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.h View 2 chunks +3 lines, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 4 chunks +19 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Fady Samuel
5 years, 8 months ago (2015-04-08 20:12:28 UTC) #2
lazyboy
lgtm
5 years, 8 months ago (2015-04-08 21:29:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065413002/1
5 years, 8 months ago (2015-04-08 21:46:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 01:08:23 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 01:09:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f5bfc1e91367878b8d632f62ae482f4205a15a3
Cr-Commit-Position: refs/heads/master@{#324327}

Powered by Google App Engine
This is Rietveld 408576698