extensions/browser/guest_view/web_view/web_view_guest.h - Issue 1065413002: <webview>: Don't reset allowtransparency and allowscaling between createGuest and attachGuest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.h

Issue 1065413002: <webview>: Don't reset allowtransparency and allowscaling between createGuest and attachGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/platform_apps/web_view/simple/main.js ('k') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_guest.h

diff --git a/extensions/browser/guest_view/web_view/web_view_guest.h b/extensions/browser/guest_view/web_view/web_view_guest.h

index d6f3e3291773a6e91af83a6b162ee90a7619da55..34f5df959a9848a05fba9a318c079cb5b78a2beb 100644

--- a/extensions/browser/guest_view/web_view/web_view_guest.h

+++ b/extensions/browser/guest_view/web_view/web_view_guest.h

@@ -89,9 +89,11 @@ class WebViewGuest : public GuestView<WebViewGuest>,

void SetZoomMode(ui_zoom::ZoomController::ZoomMode zoom_mode);

void SetAllowScaling(bool allow);

+ bool allow_scaling() const { return allow_scaling_; }

// Sets the transparency of the guest.

void SetAllowTransparency(bool allow);

+ bool allow_transparency() const { return allow_transparency_; }

// Loads a data URL with a specified base URL and virtual URL.

bool LoadDataWithBaseURL(const std::string& data_url,

@@ -364,7 +366,7 @@ class WebViewGuest : public GuestView<WebViewGuest>,

std::string name_;

// Stores whether the contents of the guest can be transparent.

- bool guest_opaque_;

+ bool allow_transparency_;

// Stores the src URL of the WebView.

GURL src_;