Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1065103002: Merge to XFA: Fix (nearly all) IWYU in fpdfskd/include/javascript/ headers. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Fix (nearly all) IWYU in fpdfskd/include/javascript/ headers. Original Review URL: https://codereview.chromium.org/1060133002 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/9a3f8123c421faae8b4573c895a7b1c0ef236205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -60 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/include/javascript/Consts.h View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/Field.h View 1 chunk +5 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/Icon.h View 1 chunk +3 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Context.h View 1 chunk +4 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Define.h View 1 chunk +0 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/JS_EventHandler.h View 1 chunk +7 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/JS_GlobalData.h View 2 chunks +3 lines, -2 lines 0 comments Download
D fpdfsdk/include/javascript/JS_Module.h View 1 chunk +0 lines, -47 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Object.h View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Runtime.h View 1 chunk +7 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Value.h View 1 chunk +3 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/PublicMethods.h View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/app.h View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/color.h View 1 chunk +3 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/console.h View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/event.h View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/global.h View 1 chunk +4 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/report.h View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M fpdfsdk/include/jsapi/fxjs_v8.h View 1 chunk +7 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR'd.
5 years, 8 months ago (2015-04-07 22:35:10 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 9a3f8123c421faae8b4573c895a7b1c0ef236205 (presubmit successful).
5 years, 8 months ago (2015-04-07 22:35:53 UTC) #2
Lei Zhang
5 years, 8 months ago (2015-04-07 22:51:18 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698